Git Product home page Git Product logo

Comments (4)

jrcichra avatar jrcichra commented on August 31, 2024 2

I'm thinking now, if the data sheet for ELM327 should have echoing on by default, it makes more sense to fix the emulator, not this codebase.

I like the ease of use this library presents. Maybe we can add checks for non-standard ELM327 behaviors and account for them.

from elmobd.

rzetterberg avatar rzetterberg commented on August 31, 2024 1

Hey @jrcichra!

I have never used an emulator before, but I have been wanting to add an emulator in the testing suite. So thanks for bring that to my attention.

Yes, the problem you are encountering has to do with the library expecting the device to echo back all commands that you send to it.

The library does two things when it is initialized:

  • Reset the device
  • Enable automatic protocol discovery

Resetting a device will cause the device to use the default factory settings, one of which is enabling echoing. This is the default behavior of a real ELM327-device according to the data sheet.

The goal of this library was to make it easy to use, hence the resetting, automatic protocol discovery, echo verification etc. However, lately I have been thinking about changing how the library works, so that only the user of the library decides which commands are sent to the device, and not the library. This (your problem) is another reason why changing how the library works is a good idea.

What I will do is change how the library works, and then I'm sure you will be able to use the emulator. After that we can look at how we could integrate the emulator in the test suite.

from elmobd.

jrcichra avatar jrcichra commented on August 31, 2024

Here's what I'm seeing stepping through with VSCode debugging:

image

from elmobd.

jrcichra avatar jrcichra commented on August 31, 2024

I'm betting it's because the mentioned library does not start with echoing...

from elmobd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.