Comments (4)
I'm thinking now, if the data sheet for ELM327 should have echoing on by default, it makes more sense to fix the emulator, not this codebase.
I like the ease of use this library presents. Maybe we can add checks for non-standard ELM327 behaviors and account for them.
from elmobd.
Hey @jrcichra!
I have never used an emulator before, but I have been wanting to add an emulator in the testing suite. So thanks for bring that to my attention.
Yes, the problem you are encountering has to do with the library expecting the device to echo back all commands that you send to it.
The library does two things when it is initialized:
- Reset the device
- Enable automatic protocol discovery
Resetting a device will cause the device to use the default factory settings, one of which is enabling echoing. This is the default behavior of a real ELM327-device according to the data sheet.
The goal of this library was to make it easy to use, hence the resetting, automatic protocol discovery, echo verification etc. However, lately I have been thinking about changing how the library works, so that only the user of the library decides which commands are sent to the device, and not the library. This (your problem) is another reason why changing how the library works is a good idea.
What I will do is change how the library works, and then I'm sure you will be able to use the emulator. After that we can look at how we could integrate the emulator in the test suite.
from elmobd.
Here's what I'm seeing stepping through with VSCode debugging:
from elmobd.
I'm betting it's because the mentioned library does not start with echoing...
from elmobd.
Related Issues (20)
- Second example in the README.org HOT 1
- Add documentation for usage on platforms other than Linux HOT 3
- Add a virtual mocked device for integration tests HOT 1
- Add ability to check if there are any trouble codes set
- Add ability to get the set trouble codes
- Byte response quantity doesn't match when running coolant_temperature / short_term_fuel_trim_bank1 HOT 1
- Add faster sensor reading
- Add "see communication log" feature
- Check supported commands results in error HOT 2
- ISSupported function in device.go incorrect for PID's outside part 1 HOT 3
- Add integration test that test all commands on a car HOT 1
- "UNABLE TO CONNECT" is given when same command is run twice HOT 3
- Ghh HOT 1
- Support connection over TCP HOT 1
- EL327 wifi HOT 2
- can this library work with multiple AT commands simultaneously HOT 1
- ELM327 cable sends different response payload that is not treated on elmobd HOT 1
- Add documentation that explains USB/bluetooth usage
- Add use cases for the behaviour of the library
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elmobd.