Git Product home page Git Product logo

Comments (5)

ryandrewjohnson avatar ryandrewjohnson commented on May 14, 2024 2

Thanks a lot for your help on this one. I ended up having to make even more type fixes, so I just pulled the changes directly from your PR #64. I have published a new version v2.17.2 which I hoping fixes all the type issues, but I did have to make one change that could result in some breaks. I had to rename the translate's function type which previously was using a type called Translate to TranslateFunction, as this was causing conflicts with the new Translate component type that also need to be named Translate.

If you could test and let me know if there are any issues that'd be greatly appreciated.

from react-localize-redux.

Qolzam avatar Qolzam commented on May 14, 2024 1

Perfect 👍 I have just tested and all working well. I greatly appreciate your fast reply and quick fix.

from react-localize-redux.

ryandrewjohnson avatar ryandrewjohnson commented on May 14, 2024

If you’re using TypeScript and able to fix on your end and submit a PR that’d be great! I’m using flow when developing, so testing the TS definitions are tougher.

If not I’ll have to have a look tomorrow.

from react-localize-redux.

Qolzam avatar Qolzam commented on May 14, 2024

I have created the pull request on #64. It solved my problems but not sure if it's the best way. TypeScript can't understand TranslateChildFunction function as a type so I have wrote a type for. Also I got error for Component<TranslateProps> which complained I can't use Component as a value, so I changed it to React.Component. Sorry for typo mistake on issue number 😞.

from react-localize-redux.

ryandrewjohnson avatar ryandrewjohnson commented on May 14, 2024

Thanks for your help on this one.

from react-localize-redux.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.