Git Product home page Git Product logo

Comments (3)

albertz avatar albertz commented on September 15, 2024 1

Two things:

AttributeError: 'DistributeFilesDataset' object has no attribute '_workers'

Because of early exception in __init__. But anyway, we should avoid this error by checking hasattr or so in __del__. But that's not really the main issue here.

The main issue is that we call _get_rank_and_size in the sub proc. Instead, this should be passed from the parent to the sub proc in serialization. We can pass some _rank and _size as args and if they are passed, use them. That should already fix it.

from returnn.

NeoLegends avatar NeoLegends commented on September 15, 2024

I think I know what this is

from returnn.

NeoLegends avatar NeoLegends commented on September 15, 2024

The main issue is that we call _get_rank_and_size in the sub proc. Instead, this should be passed from the parent to the sub proc in serialization. We can pass some _rank and _size as args and if they are passed, use them. That should already fix it.

I feel like we should rather fix the DistributedContext to properly work in and child process, no?

Never mind, I don't think this is feasible because torch will always try to "properly" initialize a process and make it part of the worker group, even if we just want to access some worker group metadata like the size and rank of the parent.

from returnn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.