Input pull-up doesn't work on expanders about johnny-five HOT 3 OPEN

I found a way to get this working. Here's more context and some follow-up questions:

I expected the following code to work:

    const expander = new five.Expander({
      controller: "MCP23017",
      address: 0x21,
    });
    const virtual = new five.Board.Virtual(expander);

    const button = new five.Button({
      board: virtual,
      isPullup: true,
      pin: 5,
    });

However, this only configures the pin to be an input pin, without the internal pull-up resistor enabled. Looking through the code, I saw that the MCP23017 code does have support for controlling the pull-up registers and I was able to get the button to work with the following code:

    const expander = new five.Expander({
      controller: "MCP23017",
      address: 0x21,
    });
    const virtual = new five.Board.Virtual(expander);

    // ADDED COMMAND
    expander.pullUp(5, virtual.io.HIGH)

    const button = new five.Button({
      board: virtual,
      isPullup: true,
      pin: 5,
    });

So I have two questions:

1. Is the expectation that the first block of code should have worked?
2. If the button API alone is not expected to work, is my current approach correct or am I reaching too far into the internals?

from johnny-five.

@scottgonzalez ,

I think if you got the workaround and its really work and makes you happy then don't ask unnecessary questions :-)

p.s. thank you for sharing your solution! 👍🏻

from johnny-five.

These are not unnecessary questions. Having to use a workaround does not make me happy and I believe this is a bug in J5.

from johnny-five.