Git Product home page Git Product logo

Comments (16)

rvolz avatar rvolz commented on August 11, 2024

A selective password protection for individual books is planned for the next version, yes. Selection by tag sounds like a neat idea.

from bicbucstriim.

blowk avatar blowk commented on August 11, 2024

Can I help with the next version? When is the next version to be planned?

from bicbucstriim.

rvolz avatar rvolz commented on August 11, 2024

In April probably, depending on the workload. Of course you could help. If you have the time you could just add the feature.

from bicbucstriim.

blowk avatar blowk commented on August 11, 2024

Ok. Thanks. I will take a look.
I have some questions about this.

  • Should it be one password for several tag(s) or for specific tags corresponding to specific passwords? (maybe first option is easier, so it can use the global password for downloading.)
  • can the books be viewed (information page) without knowing the password? (filter -> see next question)
  • are the books filtered out if the password hasn't been filled in?
  • should there be a option 'safe filter' in the right upper corner, to set the password so you can see the full catalogue?

from bicbucstriim.

rvolz avatar rvolz commented on August 11, 2024

Oh good. Thank you. The security/download protection aspect has three layers:

  1. many users seem to use BBS on the Internet and not inside their own LANs, so there will be a (optional) login protection for the whole app
  2. there still will be the global download protection
  3. instead of none or global download protection the user can opt for selective download protection

For now I would opt against filtering and go for simple download protection with one tag. More tags are hard to remember. The book information would then always be visible. This approach has the advantage that the implementation is straightforward:

  • add your tag-check to the function is_protected in index.php
  • add a tag selection div to the admin page and store the the selected tag in the database

Does that help?

from bicbucstriim.

blowk avatar blowk commented on August 11, 2024

Ok. Maybe a filter function could be a feature for later.

  1. So there need to be a optional login for the whole app -> maybe autodetect if the user is accessing the app within the same network? If not there could be the option to login? (Are you allready started with this option?)
  2. The global download protection is allready in the app so I will leave this. Ok?
  3. This selective download protection can only be activated, on one tag; if 1 en 2 isn't activated? I was thinking if option 1 is activated and 2 also. Option 2 will be desactivated when using option 3 (selective download protection based on one tag), but using the same password..

Just to be sure.

from bicbucstriim.

rvolz avatar rvolz commented on August 11, 2024

-> 1) no, I have to do some restructuring first (update Slim etc.)
-> 2) yes please
-> 3) Sounds ok

from bicbucstriim.

blowk avatar blowk commented on August 11, 2024

Ok. I will check and upload the code when finished.
I will change the language file too.

from bicbucstriim.

blowk avatar blowk commented on August 11, 2024

Is there an easy way to view to log that are produced by the app? Is there a short url for that or where does the app write it's logs?
I have to figure out where I can find the tag of the book. All I found is $details = $bbs->titleDetails($id); $allTags = $details['tags'];

Is this what I need?

from bicbucstriim.

rvolz avatar rvolz commented on August 11, 2024

The app uses the underlying Slim framework for logging and that currently logs to the Apache error log. Redirecting the log to a file didn't work reliably in Slim 1.6, unfortunately. That is part of the reason why I want to upgrade to a newer version.

Yes, this

$details = $bbs->titleDetails($id);  
$allTags = $details['tags'];

should get all book tags.

from bicbucstriim.

blowk avatar blowk commented on August 11, 2024

Ok. I think I will manage this.
As soon I get the time, I will upload the code. In language file, I will only able to upload in in English and Dutch.
Is it ok that I just place the code inside this project (click code and edit?)
Sorry for that question but it's my first time that I'm working on a project on Github.

from bicbucstriim.

rvolz avatar rvolz commented on August 11, 2024

It would be the easiest if you could just use a pull request https://help.github.com/articles/using-pull-requests

If your fork is still up to date, it should be easy for me to integrate your code.

from bicbucstriim.

janeczku avatar janeczku commented on August 11, 2024

I am running the app in the cloud as well. Book-files and calibre-database on the server are synced via the dropbox linux headless client.It works perfectly.

Now, HTTP Basic password protection for the whole app can be achieved by adding a single line of code to index.php. Great thing is, this does not break OPDS functionality, since OPDS specs require RFC2617 capability on the client side.

$app->add(new Middleware_Auth_HttpBasic('USERNAME', 'PASSWORD'));

While i am at it, there is a tiny typo in the current download archive version that throws a server error when calling the list of books for a specific tag.

--- BicBucStriim-1.0.0/index.php    2012-12-15 13:53:36.000000000 +0100
+++ Downloads/index.php 2013-03-09 02:26:46.000000000 +0100
@@ -933,7 +933,7 @@ function tagDetailsSlice ($id, $index=0)
        $book->formats = $bbs->titleGetFormats($book->id);
    $app->render('tag_detail.html',array(
        'page' => mkPage(getMessageString('tag_details')),
-    'url' => 'tag/'.$id, 
+    'url' => 'tags/'.$id, 
        'tag' => $tl['tag'], 
        'books' => $tl['entries'],
     'curpage' => $tl['page'],

BTW, i love your app. It looks very sleek and the OPDS implementation works great on my IPAD. Thumbs up!

from bicbucstriim.

rvolz avatar rvolz commented on August 11, 2024

Ok, I haven't looked too much into Slim Middleware, but your idea looks good. I'll check that.

Thanks for the hint about the tags, the fix is already in the repo (#37).

from bicbucstriim.

blowk avatar blowk commented on August 11, 2024

Hey Rvolz

I've just added it. Thanks for the info.

from bicbucstriim.

rvolz avatar rvolz commented on August 11, 2024

Thx, I'll look at it during the next days.

from bicbucstriim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.