Git Product home page Git Product logo

Comments (7)

mgattozzi avatar mgattozzi commented on May 20, 2024 1

@ashleygwilliams I personally don't mind. It's just a quick fix. It'd be nice if there was some kind of pre-push hook but you can't distribute those easily as part of a repo which has always seemed like a dumb move on git's part. I'm for keeping it to enforce style. We can always make it a part of the check list when submitting a PR by creating a template that GitHub can use.

from wasm-pack.

yoshuawuyts avatar yoshuawuyts commented on May 20, 2024

yeah, still haven't fixed it yet, but haven't put in the time yet. I don't mind having development be nightly only for now. I don't mind if it stays tbh; it's def useful!

from wasm-pack.

sendilkumarn avatar sendilkumarn commented on May 20, 2024

How about adding them in pre-push hooks?

And I do agree with @yoshuawuyts have it but don't worry about it atleast for now

from wasm-pack.

ashleygwilliams avatar ashleygwilliams commented on May 20, 2024

@sendilkumarn i think it would be just as frustrating as a pre-push hook, and a lot more to set up. i'll see what other contribs think (@mgattozzi has been bit by this so much, thankful for his patience), but sounds like we're should probably just keep it?

if someone wants to add a section to the current "up and running" section of the README about how to get cargo fmt setup correctly i would welcome a PR!

from wasm-pack.

data-pup avatar data-pup commented on May 20, 2024

I can try and add some documentation for this, having just run into this myself. If it is worth anything, getting rustfmt working was not hard, and I didn't find it too bad as a new contributor :)

from wasm-pack.

mgattozzi avatar mgattozzi commented on May 20, 2024

Awesome! :D

from wasm-pack.

ashleygwilliams avatar ashleygwilliams commented on May 20, 2024

closed by #88

from wasm-pack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.