Can't call __new__ directly to create instances. about rustpython HOT 6 CLOSED

This works now! I do not know what fixed it, but it works :)

from rustpython.

builtins.rs:

    // Special case: __new__ must be looked up on the metaclass, not the meta-metaclass as
    // per vm.call(metaclass, "__new__", ...)
    let new = metaclass.get_attr("__new__").unwrap();
    let wrapped = vm.call_get_descriptor(new, metaclass)?;

from rustpython.

Uh... no, I'm wrong. That's only during type creation, not object creation.

The correct implementation of type.__getattribute__ fixes this. (And we don't even need another special case.)

from rustpython.

In theory directly calling __new__ in Python should never be done to avoid weird side-effects. The constructor to override is always __init__.

from rustpython.

@cthulahoops this issue can now be closed, right?

from rustpython.

Yes, I think this is all fixed now.

from rustpython.