Please make `log` an optional dependency about rustls HOT 2 CLOSED

According to the documentation for log, it would seem that the log crate by itself would have very limited effect on performance. Only once your application has an actual logging implementation set up you'd see some effect. Even with some log trait implementations, I think you can trivially enable or disable logging per trait.

Have you measured the impact for this?

from rustls.

TLS can be in use for every connection on a server dong 100k connections.
There should be nothing extraneous in the critical path. In general,
libraries should not log.

That aside, the log crate's design is inappropriate. It makes logging
expensive, as it's impossible to disable per target without cost. With your
use of it it is very hard to use it for diagnosis as there is no easy way
to correlate with TCP socket activity or higher level application
protocols. If what you need is debugging then you could use an alternative.

On 10 Sep 2016 8:43 p.m., "Dirkjan Ochtman" [email protected]
wrote:

According to the documentation for log, it would seem that the log crate by
itself would have very limited effect on performance. Only once your
application has an actual logging implementation set up you'd see some
effect. Even with some log trait implementations, I think you can trivially
enable or disable logging per trait.

Have you measured the impact for this?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#22 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPx2fmBx9-WyNXUnczTyT36GIBhmFVSks5qowh3gaJpZM4J1KgE
.

from rustls.