Git Product home page Git Product logo

Comments (4)

dralley avatar dralley commented on May 8, 2024 1

That would be effectively the same as simdutf8::compat::from_utf8(value).and_then(|s| s.to_owned()), yes?

Note that there was some discussion in the past about putting it in the standard library directly: https://www.reddit.com/r/rust/comments/mvc6o5/incredibly_fast_utf8_validation/

from simdutf8.

Nugine avatar Nugine commented on May 8, 2024

Thanks for the answer!

from simdutf8.

Nugine avatar Nugine commented on May 8, 2024

Ah I forgot the original problem.
String::from_utf8 converts Vec<u8> to String with validation. However, simdutf8 can check a slice but not a vec. You have to use String::from_utf8_unchecked to bypass an extra copy. So there's still no safe replacement for that.

from simdutf8.

NightMare-Vortex avatar NightMare-Vortex commented on May 8, 2024

Looking into the implementation of from_utf8 this should be quite asy to add

#[inline]
pub fn from_utf8(input: &[u8]) -> Result<&str, Utf8Error> {
    unsafe {
        validate_utf8_basic(input)?;
        Ok(from_utf8_unchecked(input))
    }
}

and we just add

pub mod string {
    pub use super::*;
	#[inline]
	pub fn from_utf8(input: Vec<u8>) -> Result<String, Utf8Error> {
    	unsafe {
        	validate_utf8_basic(&input)?;
        	Ok(String::from_utf8_unchecked(input))
    	}
	}
}

from simdutf8.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.