bug: prometheus label issues in 1.7.0 about akka-http-metrics HOT 8 CLOSED

I'm not able to reproduce on the snapshot version. Just making sure, did you reload the project after updating the version an re-running the tests ?

yes .... from 1.6.0 to 1.7.x Dimension is no longer a trait and the withServerDimensions receives an argument 😢

but it seems that the release version is now working properly ... maybe I got a stale version of the snapshot 🤔

anyway, thanks @RustedBones !

from akka-http-metrics.

maybe related to f063d32

from akka-http-metrics.

Dammit! I thought I fixed that before releasing 1.7.0. I must have overlooked something.

I'll not be able to work on that in the coming days, so feel free to open a PR!

Thanks a lot for the bug report @cdmbr

from akka-http-metrics.

@cdmbr I published 1.7.1-SNAPSHOT. Can you give it a try and if I get a 👍 , I'll release 1.7.1 ?

from akka-http-metrics.

@RustedBones Thanks for fixing it 🥇 ... I'm not seeing the 1.7.1-SNAPSHOT in maven central yet 🤔 Have you published to a different repository ?

from akka-http-metrics.

Yes, The artifact is published in the sonatype snapshot resolver. You must add

resolvers += Resolver.sonatypeRepo("snapshots")

from akka-http-metrics.

@RustedBones

still getting some labels swapped 😢 :

akka_http_responses_size_bytes_bucket{env="local_env",method="local_stack",path="local_version",stack="GET",status="/metrics/prometheus",version="2xx",le="0.0",} 0.0
akka_http_responses_total{env="local_env",method="local_stack",path="local_version",stack="GET",status="/metrics/prometheus",version="2xx",} 2.0

config:

val prometheusSettings: PrometheusSettings = PrometheusSettings.default
    .withDurationConfig(Buckets(buckets: _*))
    .withDefineError(_.status.isFailure)
    .withIncludeMethodDimension(true)
    .withIncludePathDimension(true)
    .withIncludeStatusDimension(true)
    .withServerDimensions(
      Dimension("env", env),
      Dimension("stack", stack),
      Dimension("version", version)
    )

route:

  def routes: Route = pathLabeled("metrics" / "prometheus") {
    get { metrics(prometheusRegistry) }
  }

from akka-http-metrics.

I'm not able to reproduce on the snapshot version.
Just making sure, did you reload the project after updating the version an re-running the tests ?

from akka-http-metrics.