Numerous unused variable cause Rust difficulties about elliptic-curves HOT 3 CLOSED

Note that the code in those backends is autogenerated by fiat-crypto. An ideal fix would go into their Rust code generation backend: https://github.com/mit-plv/fiat-crypto

We do also have a tool for applying automated transformations to their output where you could also potentially apply a fix: https://github.com/RustCrypto/utils/tree/master/fiat-constify

I would definitely suggest against any hand edits to these files, as a big part of their value is formal verification.

from elliptic-curves.

Looking at https://github.com/mit-plv/fiat-crypto/blob/master/fiat-rust/src/p384_32.rs#L167 , since it's not a const fn and uses the mutable variables it declares, I don't think that warrants change, unless of course they would be changed to const fn. That would be an improvement, but probably harder to justify. I'll take a pass at modifying updating fiat-constify to strip the unused variables.

from elliptic-curves.

Sounds good!

Yeah, fiat-crypto itself should probably wait for const_mut_refs to add const fn support, since it does incur a small performance penalty.

from elliptic-curves.