Breaking change re: Error implementations on Windows about getrandom HOT 6 CLOSED

I think it should be fixed on the bcrypt side by forwarding the std feature. Plus simultaneously they also can update to getrandom v0.2, which does require such forwarding on Linux targets as well.

from getrandom.

Looks like this was resolved in Keats/rust-bcrypt#57. However, we should still probably update the 0.1 branch to fix this. It was a breaking change, and adding the std stuff back for Windows shouldn't hurt anything.

from getrandom.

IIRC std stuff never worked on Windows in the first place, so it's not a breaking change, but an inconsistency between Linux and Windows targets.

from getrandom.

IIRC std stuff never worked on Windows in the first place, so it's not a breaking change, but an inconsistency between Linux and Windows targets.

You're right.

I confirmed that v0.1.8 never had the std::error::Error implementations for Windows (unless you had the "std" feature enabled). So the removal and readding were not breaking changes on Windows. Closing as not a bug.

from getrandom.

@josephlr 0.1.6 did, though. That just means the break took place slightly earlier.

from getrandom.

@josephlr 0.1.6 did, though. That just means the break took place slightly earlier.

Good catch, reopening.

from getrandom.