Potential change/improvement current ports? about x86_64 HOT 7 CLOSED

This seems like an useful addition, thanks for proposing it! Your code looks good, would you mind creating a pull request for this?

(I would probably name the new types PortReadOnly and PortWriteOnly so that they're listed next to the Port type in the alphabetical docs.)

from x86_64.

Okay sounds good. Glad you like it. I should have time tonight to make a pr and I'll make sure to use your naming for the port types.

from x86_64.

Great, thank you!

from x86_64.

@phil-opp Do I need rights in order to create a pull request? I made a branch off of master for the changes, but I get a 403 error when I try to push it. I also only see master using the New pull request button on Github. Let me know if I need to do anything special to make a pull request.

from x86_64.

You need to create your own copy of the repository by forking it (using the fork button at the top). Then you can add the fork as a remote to your local repository:

git remote add fork url-of-your-fork

Then you can push your branch to your fork:

git push -u fork HEAD

Then you can open a pull request from your branch in RKennedy9064/x86_64 to rust-osdev/x86_64.

See https://guides.github.com/activities/forking/ for more information.

from x86_64.

Thanks for the information. I Just add a pull request for the changes I made.

from x86_64.

To link the pull request in question: #66

from x86_64.