How to use From trait to convert os_bootinfo::FrameRange into PhysFrameRange about x86_64 HOT 4 CLOSED

This requirement is rough if you want to use the latest os_bootinfo on Github or use a local os_bootinfo repository.

The problem is that we need to implement the From trait somewhere. We can't implement it in os_bootinfo, since we want to avoid any dependencies for that crate. And even if we implemented it in os_bootinfo, we would have the same problem just with different x86_64 versions.

Also, it's dangerous to use different os_bootinfo versions because they are passed over a C API, which is not type safe. If the bootloader uses a different version than the kernel, you might only get junk values. So our idea was to keep os_bootinfo as small as possible (e.g. no dependencies), so that it's as stable as possible. This means that there shouldn't be many changes to os_bootinfo in the future (maybe a few changes are still needed until we finalized the design).

from x86_64.

That's a strange error. My only idea is that this could be a version conflict, i.e. the from trait is implemented for a different version than you passed. X86_64 uses os_bootinfo version 0.2.0, maybe you're still using the alpha version?

from x86_64.

Changing my Cargo.toml to the following worked:

-os_bootinfo = { git = "https://github.com/rust-osdev/os_bootinfo" }
+os_bootinfo = "0.2.0"

I previously had x86_64, os_bootinfo, and bootloader crates pointing to the latest git revision so I could avoid using out-of-date crates 😄

This requirement is rough if you want to use the latest os_bootinfo on Github or use a local os_bootinfo repository.

from x86_64.

@robert-w-gries I think this is solved. Can we close this issue?

from x86_64.