#[inline] all the things? about x86_64 HOT 5 CLOSED

Second answer

https://internals.rust-lang.org/t/when-should-i-use-inline/598

from x86_64.

I have followed the link and read the thread, but I still have a question regarding the #[inline] attribute. In C++ an equivalent keyword also exists, but it's merely a hint for the compiler. Does Rust has a similar approach ?

from x86_64.

As far as I know, the #[inline] attribute is just a hint for the compiler that it should consider this function for cross-crate inlining. Without the attribute, inlining across crate bounds is only performed when link time optimization is enabled.

The #[inline] attribute is different from the #[inline(always)] attribute, which always forces inlining and is generally discouraged (because the compiler usually knows it better).

Should all of them be marked #[inline]? Or should users of this crate always depend on LTO?

Forcing the users to always use LTO does not seem like the best solution. So I think it's fine to add #[inline] to all such small functions of this crate and I'm happy to merge a PR for this.

from x86_64.

I have done #129 .
I'm not 100% sure of my modifications, hopefully it's just a hint, so the observable behaviour should not change.
Tested with cargo build and cargo test.
Did I miss something ?

from x86_64.

Fixed in #129.

from x86_64.