Git Product home page Git Product logo

Comments (5)

lolbinarycat avatar lolbinarycat commented on September 4, 2024

apparently this existed before in the form of --disable-minification, but was removed without discussion in #101702, however, the corrosponding config.toml option build.docs-minification was not removed, instead being silently ignored.

from rust.

lolbinarycat avatar lolbinarycat commented on September 4, 2024

silently ignoring removed options is not a good solution, especially when not all of the documentation has been updated to reflect the removal.

from rust.

lolbinarycat avatar lolbinarycat commented on September 4, 2024

the rationale for removal is that is that it would allow the contents of the file to change without the filename hash changing, but this is easily addressed by just adding nominify after the hash if minification is disabled.

from rust.

GuillaumeGomez avatar GuillaumeGomez commented on September 4, 2024

I don't mind putting back the option but you'll need to have a good use-case for it (implementing the option so it doesn't go against why it was removed originally shouldn't be too complicated).

from rust.

lolbinarycat avatar lolbinarycat commented on September 4, 2024

usecase is i don't want to do hacky and fallible symlink stuff just to get accurate line number reporting.

alternative is making a robust symlink override as part of bootstrap, but that seem like a lot more work than just reinstituting the option

from rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.