Git Product home page Git Product logo

Comments (6)

krasimirgg avatar krasimirgg commented on July 2, 2024

@ZhuUx

from rust.

ZhuUx avatar ZhuUx commented on July 2, 2024

As far as I know, works on mcdc need to be done for adapting to llvm 19 are:

  1. Eliminate the removed intrinsic function as you have done.
  2. Change the way to update condition bits as the new mechanism.
  3. Let ConditionId start from 0 rather than 1.

These changes are definite since they have been merged into llvm now, while still there are other changes may be introduced.

Given that 2 actually changes several arguments we passed to llvm and causes severe incompatibility, I'd wish to stop supporting mcdc on llvm-18 once if we switched to 19.

Edit. Other works have been done, but 2 introduces more break changes than I thought I'd need more time to adapt to it.

from rust.

Zalathar avatar Zalathar commented on July 2, 2024

In the short-term, we can just adjust the tests to not run on LLVM 19.

After the in-tree LLVM has been updated to LLVM 19, then we can remove support for MC/DC under LLVM 18, and add support for MC/DC under LLVM 19.

(Unless someone wants to do the extra work of supporting MC/DC with LLVM 19 before the official upgrade.)

from rust.

veera-sivarajan avatar veera-sivarajan commented on July 2, 2024

@rustbot label -needs-triage +A-LLVM +T-compiler +C-enhancement

from rust.

workingjubilee avatar workingjubilee commented on July 2, 2024

After the in-tree LLVM has been updated to LLVM 19, then we can remove support for MC/DC under LLVM 18, and add support for MC/DC under LLVM 19.

This sounds acceptable if we defer stabilizing MC/DC until our minimum LLVM is 19+

from rust.

ZhuUx avatar ZhuUx commented on July 2, 2024

Filed #126733 to fix it and prepare for llvm 19.

from rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.