Comments (5)
saethlin
commented on July 21, 2024
2
The git calls are highly repetitive:
177 counts
( 1) 42 (23.7%, 23.7%): execve("/usr/bin/git", ["git", "rev-parse", "HEAD"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 2) 29 (16.4%, 40.1%): execve("/usr/bin/git", ["git", "rev-parse"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 3) 26 (14.7%, 54.8%): execve("/usr/bin/git", ["git", "log", "-1", "--date=short", "--pretty=format:%cd"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 4) 26 (14.7%, 69.5%): execve("/usr/bin/git", ["git", "rev-parse", "--short=9", "HEAD"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 5) 9 ( 5.1%, 74.6%): execve("/usr/bin/git", ["git", "config", "--local", "--get-regex", "remote\\..*\\.url"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 6) 9 ( 5.1%, 79.7%): execve("/usr/bin/git", ["git", "merge-base", "upstream/master", "HEAD"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 7) 9 ( 5.1%, 84.7%): execve("/usr/bin/git", ["git", "rev-list", "[email protected]", "-n1", "--first-parent", "02c7a5921e3de5c2b3ecb2e0082c1daf"..., "--", "/home/ben/rust/src/llvm-project", "/home/ben/rust/src/bootstrap/dow"..., "/home/ben/rust/src/version"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 8) 9 ( 5.1%, 89.8%): execve("/usr/bin/git", ["git", "rev-parse", "upstream/master"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 9) 4 ( 2.3%, 92.1%): execve("/usr/bin/git", ["git", "ls-tree", "HEAD", "library/stdarch"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 10) 2 ( 1.1%, 93.2%): execve("/usr/bin/git", ["git", "ls-tree", "HEAD", "library/backtrace"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 11) 2 ( 1.1%, 94.4%): execve("/usr/bin/git", ["git", "ls-tree", "HEAD", "src/doc/book"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 12) 2 ( 1.1%, 95.5%): execve("/usr/bin/git", ["git", "ls-tree", "HEAD", "src/tools/cargo"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 13) 1 ( 0.6%, 96.0%): execve("/usr/bin/git", ["git", "config", "--file", "/home/ben/rust/.gitmodules", "--get-regexp", "path"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 14) 1 ( 0.6%, 96.6%): execve("/usr/bin/git", ["git", "ls-tree", "HEAD", "src/doc/edition-guide"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 15) 1 ( 0.6%, 97.2%): execve("/usr/bin/git", ["git", "ls-tree", "HEAD", "src/doc/embedded-book"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 16) 1 ( 0.6%, 97.7%): execve("/usr/bin/git", ["git", "ls-tree", "HEAD", "src/doc/nomicon"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 17) 1 ( 0.6%, 98.3%): execve("/usr/bin/git", ["git", "ls-tree", "HEAD", "src/doc/reference"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 18) 1 ( 0.6%, 98.9%): execve("/usr/bin/git", ["git", "ls-tree", "HEAD", "src/doc/rust-by-example"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 19) 1 ( 0.6%, 99.4%): execve("/usr/bin/git", ["git", "ls-tree", "HEAD", "src/tools/rustc-perf"], 0x7ffdf49142d8 /* 46 vars */) = 0
( 20) 1 ( 0.6%,100.0%): execve("/usr/bin/git", ["git", "rev-parse", "--show-cdup"], 0x7ffdf49142d8 /* 46 vars */) = 0
And based on the flamegraph above, most of the runtime of git is in process startup. Caching these somehow seems sensible.
from rust.
Kobzol
commented on July 21, 2024
This also annoys me. I'll try to profile it in a bit more detail.
from rust.
Kobzol
commented on July 21, 2024
Seems like about a half of that duration on Linux is spent inside strip_debug, where we invoke strip on the compiler artifacts. BFD is unfortunately quite slow here, and takes about 1.2s on my system (so about half the time) to strip the compiler binary. I'll try to investigate if we can get rid of it.
Edit: this only happens if you set rust.debuginfo-level = 0, see this.
from rust.
Kobzol
commented on July 21, 2024
Apart from stripping, the rest is #126467 + a bunch of cargo and git invocations, but that was already clear from the flamechart.
from rust.
Kobzol
commented on July 21, 2024
That's a good point! Onur has an open PR that centralizes the git invocations in bootstrap, once that's merged, it will be easier to cache them, I'll take a look at it.
Also, running git gc can help a lot, from time to time. Maybe bootstrap could do it periodically.
from rust.
Related Issues (20)
- Trouble setting `default-linker = ...` when building aarch64-unknown-linux-musl Rust target HOT 5
- Return type notation with constant parameter can potentially cause misleading diagnostics
- Async closure argument inference is broken with functions taking `FnOnce() -> futures::TryFuture` HOT 2
- note: this failure-note originates in the macro `diesel::table` HOT 2
- run-make: add a `//@ needs-symlink` directive over `//@ ignore-windows` HOT 1
- Adding an `impl for type defined outside of crate` causes every associated method call to be reported as an error
- The expected type vs. found type in the error `one type is more general than the other` HOT 1
- Detect boolean literals in logical expressions HOT 3
- internal compiler error: cannot convert `'{erased}` to a region vid HOT 1
- ICE `index out of bounds: the len is 0 but the index is 0` HOT 1
- `binary_asm_labels` should suggest a change HOT 3
- ICE: `bpos.to_u32() >= mbc.pos.to_u32() + mbc.bytes as u32` HOT 4
- ICE: `failed to resolve instance for ErrorGuaranteed()` HOT 1
- aarch64-pointer-auth test failing on LLVM 19 HOT 1
- Poorly-documented safety assumptions in `unix::stack_overflow::init` HOT 6
- Bootstrap using `set_times` on a read-only file
- Compiler marks import as unnecessary when it isn't (panic_handler) HOT 3
- Corrupted data trashes the output HOT 7
- Confusing CI error when compiler build fails HOT 7
- unreachable pattern lint should report some (or all) of the earlier match arms that subsume the unreachable one HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust.