Comments (4)
Something peculiar about many of these tests is that transforms seem to create ALLOCs that are not actually referenced by MIR. Is that expected?
In terms of fixing this, the existing approach of picking constants that are endianness-independent doesn't seem very scalable. Maybe it would make sense to have a flag that disables dumping the contents of allocations? I think that for most of these tests they are not relevant (especially as the allocations are unused in the first place).
from rust.
Something peculiar about many of these tests is that transforms seem to create ALLOCs that are not actually referenced by MIR. Is that expected?
This appears to be an intermediate result of the optimization process, such as: https://rust.godbolt.org/z/ohz1YMqez (tests/mir-opt/const_prop/slice_len.rs).
In terms of fixing this, the existing approach of picking constants that are endianness-independent doesn't seem very scalable. Maybe it would make sense to have a flag that disables dumping the contents of allocations? I think that for most of these tests they are not relevant (especially as the allocations are unused in the first place).
There is an option ignore-endian-big
to skip these tests, but I like another option to change the output to be uniformly little-endian.
from rust.
If these tests don't actually care about the raw bytes in their UI comparisons, then they can use normalize-stderr-test
to hide the bytes. There are quite a few tests that already normalize to the string "HEX_DUMP".
from rust.
Rather than trying to normalize output, I'm proposing an option in #126502 to skip the raw bytes altogether.
from rust.
Related Issues (20)
- Tracking Issue for async drop codegen HOT 1
- Error tainting in parallel compiler HOT 2
- Cargo check internal error (using UOM library) HOT 3
- document for E0502 insufficiently general
- "deny" lints are ignored in macro expansion HOT 1
- Trait bound order-dependent type errors using non_lifetime_binders HOT 1
- ICE: incr: `no entry found for key` HOT 4
- Compiler hangs on recursive HRTB HOT 2
- Regression between nightlies with `-Zpolonius` HOT 4
- ICE: `assertion failed: matches!(diagnostic.level, Error | Warning | Allow)` HOT 2
- "rustc-LLVM ERROR: underestimated function size" on thumbv6m-none-eabi HOT 6
- `invalid_value` does not warn when transmuting from a unit struct to an uninhabited type
- Words in `<code></code>` in docs make machine translation even weirder than usual HOT 3
- ICE: `assert_eq!(alloc.mutability, mutability)` failed in `validity.rs` HOT 4
- Confusing "the caller chooses a type which can be different" [E308] HOT 4
- Async code causes error "one type is more general than the other" (expected `async` block, found that same `async` block) when demanding an `impl Send` HOT 1
- Extremely un-informative error when a future that capture the environment is used as Send
- Async code causes error "implementation of `FnOnce` is not general enough" when demanding an `impl Send`
- `tidy` requires `src/tools/rustc-perf`? HOT 1
- 1.79 regression in `const` temporary lifetime extension HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust.