"./x.py run miri --stage 1" no longer works about rust HOT 5 CLOSED

somehow Miri searches for its sysroot in stage0-sysroot instead of its own built sysroot?

from rust.

When executing Miri:

[src/tools/miri/src/bin/miri.rs:359:5] std::env::var("MIRI_SYSROOT") = Ok(
    "/home/nora/projects/rust/build/x86_64-unknown-linux-gnu/miri-sysroot",
)
[src/tools/miri/src/bin/miri.rs:360:5] std::env::args().collect::<Vec<_>>() = [
    "build/x86_64-unknown-linux-gnu/stage0-tools/x86_64-unknown-linux-gnu/release/miri",
    "--target",
    "x86_64-unknown-linux-gnu",
    "uwu2.rs",
]

I thought the sysroot was passed to the process with --sysroot, but I cannot find such an argument... how exactly does it find stage0-sysroot from this... I don't really understand how that works. But this may help.

from rust.

I see, it gets the sysroot because librustc_driver.so is in stage0-sysroot. Slightly strange, that sysroot is not really one it can use. Why is it linked from there? But either way, the sysroot we want to use for Miri here is an entirely different one that needs to be override manually. How did that work previously?

from rust.

oh lol, this was almost certainly broken by rust-lang/miri#3411, in which you even specifically mentioned x.py run, looks like you forgot about it :D

from rust.

from rust.