Git Product home page Git Product logo

Comments (2)

the8472 avatar the8472 commented on July 18, 2024

Unfortunately, wrapping Foo in Option<_> does not make use of the remaining niche: It could set both niches to null (basically selecting the Foo::B variant and nulling the Arc's NotNull pointer) to indicate the None variant.

That would require two-usize comparison (or arbitrarily-wide comparison if this scheme were extended to more fields) which is more expensive than single-register operation.

#119507 could be related, but it's about structs. Not sure if that qualifies as dup.

Enum variant payload and struct layout share the same code. So yes, it's quite similar. Though that issue talks about 2x NonZeroU8, which could still be merged into a single register.

from rust.

horazont avatar horazont commented on July 18, 2024

Unfortunately, wrapping Foo in Option<_> does not make use of the remaining niche: It could set both niches to null (basically selecting the Foo::B variant and nulling the Arc's NotNull pointer) to indicate the None variant.

That would require two-usize comparison (or arbitrarily-wide comparison if this scheme were extended to more fields) which is more expensive than single-register operation.

Aha, indeed. I had noticed that two reads are needed for the Some(_) variants, which is the same in the non-inlined case. I did not see that two reads would then also needed for the None variant, which is of course a drawback.

from rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.