nightly rustdoc on doc.rust-lang.org has broken search and missing colours about rust HOT 26 CLOSED

Setting the priority to critical, this is not acceptable.

from rust.

Discussed on Zulip. It looks like the root cause of this is #123246, which adjusted our tarballs to have old modification timestamps. That broke the doc upload in promote-release, which currently relies on modification timestamps being newer in the new nightly (otherwise that file isn't replaced in S3).

@Kobzol is going to work on a patch and I'm testing against dev-static a manual upload (and will apply it to proper static if it works) now.

from rust.

aws s3 sync sadly cannot compare checksums at the moment. Right now we have decided to simply touch all doc files that we upload to S3, therefore the modification times should be always updated.

from rust.

I only fixed the std docs through a manual copy. Rustc docs should be fixed in a few hours with the next nightly.

from rust.

The search functionality (JS-based) doesn't work either. Certain static JS files don't get loaded leading to the theme not getting set in turn leading to the CSS variables not being defined. I can reproduce this locally, somewhat. Therefore I don't think this is an infra issue.

from rust.

Over at https://doc.rust-lang.org/nightly/settings.html, I get the following errors:

error: GET https://doc.rust-lang.org/nightly/static.files/storage-4c98445ec4002617.js [HTTP/3 404  23ms]
error: GET https://doc.rust-lang.org/nightly/static.files/main-12cf3b4f4f9dc36d.js [HTTP/3 404  20ms]
warning: Loading failed for the <script> with source “https://doc.rust-lang.org/nightly/static.files/storage-4c98445ec4002617.js”. settings.html:1:1502
error: GET https://doc.rust-lang.org/nightly/static.files/main-12cf3b4f4f9dc36d.js [HTTP/3 404  8ms]
warning: Loading failed for the <script> with source “https://doc.rust-lang.org/nightly/static.files/main-12cf3b4f4f9dc36d.js”. settings.html:1:1571
error: Uncaught ReferenceError: getVar is not defined
    buildSettingsPage https://doc.rust-lang.org/nightly/static.files/settings-4313503d2e1961c2.js:17
    <anonymous> https://doc.rust-lang.org/nightly/static.files/settings-4313503d2e1961c2.js:17
    <anonymous> https://doc.rust-lang.org/nightly/static.files/settings-4313503d2e1961c2.js:17
warning: The resource at “https://doc.rust-lang.org/nightly/static.files/SourceCodePro-Regular-562dcc5011b6de7d.ttf.woff2” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. settings.html
warning: The resource at “https://doc.rust-lang.org/nightly/static.files/SourceCodePro-Semibold-d899c5a5c4aeb14a.ttf.woff2” preloaded with link preload was not used within a few seconds. Make sure all attributes of the preload tag are set correctly. settings.html

​

from rust.

Locally with master rustdoc (rev 8938f88), when I try to search anything, I get:

Uncaught TypeError: this.string is undefined
    next file:///home/fmease/programming/rust/doc/static.files/search-ffac13a0df2b1870.js:5
    buildIndex file:///home/fmease/programming/rust/doc/static.files/search-ffac13a0df2b1870.js:5
    initSearch file:///home/fmease/programming/rust/doc/static.files/search-ffac13a0df2b1870.js:5
    <anonymous> file:///home/fmease/programming/rust/doc/static.files/search-ffac13a0df2b1870.js:5
    <anonymous> file:///home/fmease/programming/rust/doc/static.files/search-ffac13a0df2b1870.js:5

from rust.

Ah but when I clear doc/ and rebuild the docs again, it works. Might have something to do with the hash? Not sure what's going on.

cc @GuillaumeGomez @notriddle

from rust.

Yeah nightly rustdoc is pretty broken, affects both nightly std docs and rustc API docs.
Cc @rust-lang/rustdoc

from rust.

The version number on the settings page is 1.79.0-nightly (8df7e723e 2024-03-30) so it seems like it might have only partially updated and there's an inconsistent set of files available (old html but new js).

from rust.

Just tested locally and everything works. Checking if I can reproduce the search bug @fmease mentioned.

from rust.

Can't reproduce search bug either...

from rust.

Ah that might've been a weird edge case? Basically I had a preexisting dirty doc/ folder.

from rust.

That was my theory: an existing search index would get updated and not be working because the new search index version is completely different.

from rust.

But surely y'all can't search over at https://doc.rust-lang.org/nightly/nightly-rustc/ either?

from rust.

No but it seems like the linked JS files are not even present on the server. We might need the infra team to figure out what's going on.

from rust.

Discussion on zulip

from rust.

Cc @rust-lang/infra

from rust.

Presumably the modification timestamps for files could instead be set to the maximum modification time of their sources, rather than just a set low time point? It's more difficult to do that, but that way you preserve the usefulness of the times without losing the reproducibility. You could start broad, just maxing the update time of all JS/CSS/Rust files, then maybe going finer if you need it. (I believe git has a setting to override mtimes to commit times, rather than actual modification times?)

Or, the upload check could just go by checksums instead of timestamps, since I know S3 already stores those for you and supports using ETags for you update-if-changed too.

from rust.

Presumably the modification timestamps for files could instead be set to the maximum modification time of their sources

That's still not reproducible and timestamps will differ between different systems.

from rust.

Right, I had just added an edit between making that post and seeing yours that clarifies that git has settings to ensure checked out files have mtimes set to the times for the commits, not when they're checked out, ensuring it's the same for the repo if no changes are made in the meantime.

from rust.

That's fair, and I do see that the docs are fixed now. Since we confirmed this is just an infra issue and it was fixed, I guess we should close this?

from rust.

https://doc.rust-lang.org/nightly/nightly-rustc/?search=NullOp is still broken.

from rust.

The nightly should have happened but https://doc.rust-lang.org/nightly/nightly-rustc/?search=NullOp is still broken.

from rust.

Should be working properly now.

from rust.

It does, thanks. :)

from rust.