Make use of LSP file system operations about rust-analyzer HOT 6 CLOSED

Should this be closed by #415?

from rust-analyzer.

There are two bits I'd love to investigate with the new implementation: If I now type mod frobnicate; and apply a fix to create frobnicate.rs, the file gets created, but

• editor is not focused to it (that is, file with mod frobnicate; is still opened, not the new file)
• language server does not receive notification that file is created.

The second is a "bug" in the server implementation: it should listen to file system events, but it doesn't at this point.

The first one looks like something does not work on the typescript side of things. I expect that fixing first should also be a work-around for the second.

from rust-analyzer.

My current suspicions is that created/moved are not assigned for some reason: https://github.com/rust-analyzer/rust-analyzer/blob/481713a0e17e1557288e88a6b1a173b111792998/editors/code/src/commands/apply_source_change.ts#L17-L21

from rust-analyzer.

It turns out that there's multiple overloads of vscode.workspace.openTextDocument and we should use https://code.visualstudio.com/api/references/vscode-api#2280 but if a string is passed it means something different.

from rust-analyzer.

Now that that's working a textDocument/didOpen and then a textDocument/publishDiagnostics notification is recieved for the new file, should there be others?

from rust-analyzer.

It turns out that there's multiple overloads of vscode.workspace.openTextDocument and we should use https://code.visualstudio.com/api/references/vscode-api#2280 but if a string is passed it means something different.

😨

Now that that's working a textDocument/didOpen and then a textDocument/publishDiagnostics notification is recieved for the new file, should there be others?

No, that's all that is expected. It would still be good to fix underlying vfs issue, but that can be tricky. Opened #433 for that.

from rust-analyzer.