[Feature Request] Add configurable linking modifiers about pkg-config-rs HOT 6 CLOSED

Thanks for the update!

from pkg-config-rs.

Wouldn't the more correct way to deal with this be to add these linker flags to the pkg-config file for these object files?

from pkg-config-rs.

Wouldn't the more correct way to deal with this be to add these linker flags to the pkg-config file for these object files?

That's one solution. My problem is within a large enterprise codebase where I do not have access to modify the many packages and dependencies that I need now and will need over time. With rustc defaulting to +whole-archive for every single library - not just the problematic ones - this leads to a lot of unnecessary code getting linked in.

from pkg-config-rs.

We've also discovered a related issue with rustc that would make this change unusable for now. This section of the compiler ends the link step if any two packages with the same names have modifiers; not if they have different modifiers, but if they have any at all. So if we were able to add linking modifiers in this crate, it would error if any explicit dependencies share a dependency.

from pkg-config-rs.

How would you like this to work btw? Having API to specify per package, or even per library, linking modifiers? This seems like the wrong place for doing that to me. No other language I'm aware of needs this when consuming pkg-config files :)

from pkg-config-rs.

So actually I think we can close this. It is not an issue with pkg-config but an issue with rustc where cargo test defaults to whole-archive. Thanks for chatting :)

from pkg-config-rs.