Comments (3)
Turns out the issue is that Windows SystemTime does not support time intervals smaller than 100 nanoseconds. The tests are using intervals much smaller than that and when we add a duration to system times that are smaller than 100 nanoseconds, you'll end up not actually adding any time (i.e., the system time you get after the addition is the same as the one before).
You can see where we divide nanoseconds into 100 nanosecond chunks in stdlib here.
To fix this we need to use a time mechanism that has more precision than 100 nanosecond intervals.
from measureme.
@eddyb mentioned that a fix for this should also take care of the case when we are not actually dealing with timestamps, such as when recording instructions counts.
from measureme.
For generalized handling of counters, we've been serializing this as counter.units
in the JSON:
measureme/measureme/src/counters.rs
Lines 148 to 158 in 1d904b7
So we should be able to pretty-print an u64
that measures nanoseconds, as the appropriate unit for a maximum number of "significant digits". It's just going to be annoying to thread that state through.
from measureme.
Related Issues (20)
- Make a new release HOT 1
- CSV output from mmview
- meta executable
- `Option::unwrap()` on a `None` value HOT 3
- compile error while attempting to install measureme on current nightly HOT 1
- Documentation still says that measureme generates three files HOT 1
- Make it easier to transition between versions HOT 10
- Make installation instructions stable HOT 5
- Name collisions HOT 1
- Add constants for artifact kinds to measureme/src/rustc.rs
- Option::unwrap() on a None value when building vector
- `summarize` segfaults on large .mm_profdata files HOT 3
- Job 1, `summarize summarize test.mm_profdata` terminated by signal SIGSEGV (Address boundary error) HOT 1
- Could not parse `event_id`. Found ASCII control character in <text> HOT 9
- random segfault HOT 8
- Better handling of multiple profiles
- Many "Children are longer than parent" warnings when loading crox output in chromium profiler
- Seeing ICE due to u32 overflow HOT 6
- Segmentation fault when following example HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from measureme.