Comments (3)
m-ou-se
commented on September 2, 2024
That's weird. It specifically excludes the author of the PR here:
Line 306 in a2e3b19
Which comes from the last argument here:
Lines 384 to 386 in a2e3b19
Set here:
Line 369 in a2e3b19
from highfive.
m-ou-se
commented on September 2, 2024
Ah, the casing of your username in the high-five config doesn't match the one github uses: JoshTriplett vs joshtriplett
If you click [edit] on rust-lang/rust#84257 (comment), you can see the bot is using JoshTriplett and not joshtriplett (even though github shows the former as the latter).
from highfive.
joshtriplett
commented on September 2, 2024
@m-ou-se Ah, interesting. Ideally the bot should match ignoring case the same way GitHub does, but in the meantime, it sounds like the easiest fix would be to change my username in the configuration to all-lowercase.
from highfive.
Related Issues (20)
- Add some local tests
- rust-highfive only warns about updated submodules when a PR is created HOT 4
- Remove jemalloc config
- `r? @rust-highfive` to reassign a review randomly (again) HOT 1
- naive startswith can cover wrong directories for "mentions" HOT 1
- directory choice only examines first two components HOT 1
- feature request: warn if src/test/ is modified without modifying compiler/ or src/librustdoc/ HOT 5
- Warn on change to targets HOT 1
- Please detect commits that mark an API as stable and display a warning
- Warn when `r?`d username doesn't have `r+` rights
- Mention notifications for changes to subtrees HOT 8
- Add link to rustbot commands in first message
- Why is it written in Python? 👀 HOT 1
- Add repo link to the `rust-highfive` user account
- Update rust config to add wgs/projects
- Give helpful info with r? is invalid HOT 1
- highfives misses some PRs HOT 1
- no longer can assign specific users HOT 1
- Re-assigning can assign the current assignee HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from highfive.