Consider not dropping entries on panicky rehashes about hashbrown HOT 2 OPEN

I am looking into other workarounds in my code; but I think this is a useful property for both hashbrown and the stdlib to try and maintain for the uses of all unsafe code, not just mine. And it's not just useful, it's an easy assumption to make.

Append-only collections are a common pattern and I've seen this kind of logic used outside of elsa as well. I think others will make this assumption in the future; and ideally they would be able to.

I could ask upstream that this property be codified in the docs once we have it settled here.

from hashbrown.

The relevant code is here: https://github.com/rust-lang/hashbrown/blob/3b348eaac93c5ee60f7ce1ff5a246e86782497d1/src/raw/mod.rs#L2277C45-L2277C46

I suppose we could just mark the elements as having a hash value 0 instead of deleting them, however this is a deep implementation detail of the hash table. Consider the future where we replace the standard library hash table implementation yet again. It would not be possible to guarantee that this behavior remains the same.

My recommendation would be to look into a different workaround in your own code.

from hashbrown.