Duplicate rustflags should be de-duplicated about cargo HOT 4 OPEN

Possibly shares subjects with #5376 but is not exactly the same problem.

from cargo.

However I use this crate as part of a workspace. So I also put the previous config.toml in my workspace .cargo/config.toml.

So it sounds like you have

workspace/
  Cargo.toml
  .cargo/config.toml
  crateA/
    .cargo/config.toml
    Cargo.toml

Is that right?

is there a reason you do both configs, rather than just the workspace config?

As for de-duplicating, to do that would require us to have knowledge of rustc's CLI

• To detect related names for arguments (short and long forms, aliases)
• To know when -abc is -a -b -c or -a bc
• To properly handle multiple values for an argument

Most CLIs are not written in a way to be able to reuse the same definition for parsing as de-duplicating, so we'd have to fork their CLI and keep it in sync.

from cargo.

So it sounds like you have

workspace/
  Cargo.toml
  .cargo/config.toml
  crateA/
    .cargo/config.toml
    Cargo.toml

Exactly.

is there a reason you do both configs, rather than just the workspace config?

The crateA is versionned in its own git and I would like users to keep being able to just pull and run instead of having to mess with cargo config.

As for de-duplicating, to do that would require us to have knowledge of rustc's CLI

I understand that what I'm asking is far from trivial ☹️ But at the same time it's super weird to see cargo rebuild all the crate because having multiple times the same flag (or even just not in the same order) is considered different.

from cargo.