Hi, thanks for the book and the much helping source code. I think I found a proble

Your definition of NTP offset is wrong about code HOT 3 CLOSED

rust-in-action commented on May 30, 2024 2

Your definition of NTP offset is wrong

from code.

Comments (3)

timClicks commented on May 30, 2024 1

Wow, that's a significant mistake. Thank you very much for pointing it out.

Now that Rust has Unicode identifiers, I wonder if I should update the code to make use of them. Probably not with this edition.

from code.

timClicks commented on May 30, 2024

Interestingly, it's correct later in the definition of delay()

code/ch9/ch9-clock3/src/main.rs

Lines 46 to 49 in cff02d5

 fn delay(&self) -> i64 { 

 let duration = (self.t4 - self.t1) - (self.t3 - self.t2); 

 duration.num_milliseconds() 

 }

from code.

8thMage commented on May 30, 2024

I'm sorry but this has the same value, just the different t's are in different permutation. The offset should not have been delay / 2, but the t's in different signs. Should I open a pr?

from code.

Related Issues (20)

ch8/ch8-mget: build fails immediately due to misformed TOML in Cargo.toml HOT 1
ch10/ch10-render-hex-threadpool: does not match Listing 10.28, or compile
ch12/asm.rs: asm!() is in stable rust (since 1.59), different use syntax
add .gitignore with target/ pattern
ch4: short-lived strategy
ch5: incorrect value for skip operation
ch8/ch8-mget freezes on polling state=Request is_active=true may_send=false can_recv=false may_recv=false
ch6/ch6-particles fails with missing libX11.so.6 HOT 1
ActionKV function find() not working properly?
ch2-mandelbrot: could not compile `num-bigint` (lib) due to 4 previous errors HOT 3
ch11: ch11-fledge-os-2 unexpected package.metadata.bootimage key default-target
ch7: actionkv v2.0 does not resolve the problem in actionkv v1.0 HOT 6
NTP offset definition in book and source code is incorrect HOT 1
ch12-sjlj Why the program not execute the line `println!("early return!");`, set_jmp and long_jmp didn`t work. HOT 2
ch11-fledgeos-0 not building. Fix provided. Error: feature(const_fn) has been removed HOT 2
Chapter 10, 10.18, ch10-render-hex, Mac OS X
ch6/ch6-particles does not compile on MacOS with `zsh: illegal hardware instruction cargo run` HOT 7
Chapter 5 listing 5.4 ch5/ch5-bit-pattern.rs doesn't compile HOT 1
ch8/ch8-simple: reqwest fails to connect with rust 1.66: Invalid argument
ch8/ch8-resolve: does not build with Rust 1.66 (transmute size mismatch in socket2) HOT 2

Your definition of NTP offset is wrong about code HOT 3 CLOSED

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	fn delay(&self) -> i64 {
	let duration = (self.t4 - self.t1) - (self.t3 - self.t2);
	duration.num_milliseconds()
	}