Git Product home page Git Product logo

Comments (3)

qrasmont avatar qrasmont commented on May 23, 2024

Hi,

This means Serial::open should become a wrapper around serialport::TTYPort::open instead of serial_unix::TTYPort::open.

Is it then ok to modify the Serial::open signature to match the arguments expected by serialport::TTYPort::open ? Or should the existing signature be preserved ?

from linux-embedded-hal.

eldruin avatar eldruin commented on May 23, 2024

Keeping the signature is not a must. It would be nice to keep if possible, though, just because it is currently very straight-forward by simply providing a path.
We have a breaking release in the pipeline so if you are interested, now it would be a great time to have a go at it.

from linux-embedded-hal.

qrasmont avatar qrasmont commented on May 23, 2024

The main difference is that serial-rs would rely on termios to get the baud rate while serialport-rs requires the user to provide it to be able to open the port.

So the signature could be maintained by using termios.

from linux-embedded-hal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.