Git Product home page Git Product logo

Comments (11)

therealprof avatar therealprof commented on May 22, 2024

@memoryruins So you're proposing to revert #1? I'm more in favour to go with #20 instead which would also remove a lot of the badges from the entry page to unclutter the entry page.

from awesome-embedded-rust.

memoryruins avatar memoryruins commented on May 22, 2024

Ah yes, my bad. I would have left a comment there if I saw earlier. Many awesome lists do without, and the ones that add structure and alignment, e.g https://github.com/bnb/awesome-hyper, still experience sluggish load times.

I’m also in favor of splitting certain sections into their own pages, and less badges may be best in the long run there as well.

from awesome-embedded-rust.

berkus avatar berkus commented on May 22, 2024

I don't like those badges either, they're cluttering the page.

from awesome-embedded-rust.

RandomInsano avatar RandomInsano commented on May 22, 2024

Exhuming this thread from the dead, I do think removing the badges is a good plan. @japaric what was the original reason to add them? They’re neat but was there other reasons than the coolness factor?

The practical reason I can see is to check for newer versions of crates in one place.

from awesome-embedded-rust.

eldruin avatar eldruin commented on May 22, 2024

Aside from the coolness factor, it has been useful to me to distinguish which projects have a published crate and which ones do not.
Personally, for the ones with a published crate I assume that the library is usable, there is a reliable versioning and a somewhat thought-through API, even if it is not complete.
Without a published crate I expect more of an unstable and not very usable project.

The slow loading is somewhat annoying, though. Would this be better if we used pngs instead of svgs?

from awesome-embedded-rust.

therealprof avatar therealprof commented on May 22, 2024

@eldruin If this is done right (haven't checked) SVGs would be vastly smaller than PNGs. I think the main problem here is that each image is individually loaded from the server...

from awesome-embedded-rust.

RandomInsano avatar RandomInsano commented on May 22, 2024

vastly smaller

Depends on the resolution of the rendered image. A one pixel bitmap beats them all.

It could be the browser implementation of parsing and walking a new complex data structure each image that is the delay we’re seeing.

Update: (now with facts!)

-rw-rw-rw-@ 1 me  staff  3060 29 Sep 09:09 lpc82x.png
-rw-rw-rw-@ 1 me  staff   963 29 Sep 09:09 lpc82x.svg

Forced full refresh of:
SVG: 1.56MB, between 16 to 20 seconds
PNG: 1.69 MB, 9.5 seconds first refresh, 2 seconds

SVG:
image

PNG:
image

If I were to guess, the badge generator or one of it's content delivery network servers is not caching SVGs. I had the browser cache disabled for both tests and they were performed on Firefox 61.0.2.

Considering that drastic improvement, I've opened a PR for this change and we can keep arguing if it's ugly or not later.

from awesome-embedded-rust.

therealprof avatar therealprof commented on May 22, 2024

Sorry, but I don't see any improvement here. It neither renders faster for me nor would I consider it a fattening the already big page further a worthwhile tradeoff.

from awesome-embedded-rust.

RandomInsano avatar RandomInsano commented on May 22, 2024

Really?! Can you open your browsers profiler, disable caching (both FF and Chrome support this) and check the networking timeline?

Update: I just did it myself (for science!) and you're right. Yesterday I ran refreshes about five or six times per page and it seemed to be consistent. Today they're inconsistent in both browsers. As good as 1.07 seconds on one load and as bad as 20 seconds in others regardless of the content type served up.

I think these speed differences are mostly in the caching somewhere out on the Internet. I'll go close that one off.

from awesome-embedded-rust.

Israel-Laguan avatar Israel-Laguan commented on May 22, 2024

As there is already a failed test for this change, maybe this PR needs to be closed.

from awesome-embedded-rust.

berkus avatar berkus commented on May 22, 2024

I'll go and close this - seems like the consensus is to not proceed.

from awesome-embedded-rust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.