Git Product home page Git Product logo

Comments (4)

vadixidav avatar vadixidav commented on September 24, 2024

Go for it. My focus was mainly on the functionality initially, but, by all means, add any tests and benchmarks you want. I only benchmarked this crate indirectly using hgg, but a direct benchmark would be excellent. Thanks for contributing!

from header-vec.

makoConstruct avatar makoConstruct commented on September 24, 2024

resolved #3

Hm, so, to discuss the results, it's getting numbers like

running 6 tests
test test_header_vec_create          ... bench:     246,006 ns/iter (+/- 1,133,418)
test test_header_vec_create_smaller  ... bench:       2,871 ns/iter (+/- 4,370)
test test_header_vec_read            ... bench:         507 ns/iter (+/- 41)
test test_regular_vec_create         ... bench:       3,258 ns/iter (+/- 274)
test test_regular_vec_create_smaller ... bench:         829 ns/iter (+/- 80)
test test_regular_vec_read           ... bench:         509 ns/iter (+/- 14)

Which is not the best. The test_header_vec_create bench's runtime varies between being a factor of 4 to 60 times slower than test_regular_vec_create. The extremeness of that variance could have something to do with bencher using too much memory and with my linux box being deeply stuck in swap right now, so I'm going to reboot and run it again.

from header-vec.

makoConstruct avatar makoConstruct commented on September 24, 2024

Okay I rebooted, results far less dire. header vec is about 4.3x slower.

running 6 tests
test test_header_vec_create          ... bench:      10,746 ns/iter (+/- 932)
test test_header_vec_create_smaller  ... bench:       2,562 ns/iter (+/- 55)
test test_header_vec_read            ... bench:         472 ns/iter (+/- 12)
test test_regular_vec_create         ... bench:       2,922 ns/iter (+/- 98)
test test_regular_vec_create_smaller ... bench:         792 ns/iter (+/- 44)
test test_regular_vec_read           ... bench:         470 ns/iter (+/- 12)

from header-vec.

vadixidav avatar vadixidav commented on September 24, 2024

Yeah, I will open a tracking issue to see if we can get closer to Vec performance. That could help speed up hgg, and I would be pretty happy about that. Thanks again for the benchmarks and posting the results, that is so helpful.

from header-vec.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.