Relative links broken in MarkdownCommon about blackfriday HOT 6 CLOSED

#81 is related.

It fixed relative links, but it considers only those links that start with / to be relative.

See func isRelativeLink(link []byte) (yes bool) for the current logic of what constitutes a relative link.

So, if you apply this patch to your example:

diff --git a/gistfile1.go b/gistfile1.go
index 19f4e6e..07adaf6 100644
--- a/gistfile1.go
+++ b/gistfile1.go
@@ -7,8 +7,8 @@ import (

 func main() {
    outb := blackfriday.MarkdownCommon([]byte(`
-![pic](media/pic.png)
-[url](docs/doc.html)
+![pic](/media/pic.png)
+[url](/docs/doc.html)
 `))
    fmt.Print(string(outb))
 }
\ No newline at end of file

Then the output is:

<p><img src="/media/pic.png" alt="pic"/>

<a href="/docs/doc.html">url</a></p>

Can you confirm/deny if that solves your problem?

from blackfriday.

It does allow the Markdown to render the URL - however in my case that is the wrong URL. Starting with slash is an absolute reference to the server root, not a relative reference. My pages are rooted in another location, so I need a true relative reference. It seems like isRelativeLink is actually testing for an absolute link on the same server.

from blackfriday.

Note that relative URLs are notoriously hard to sanitise - make sure that
this doesn't compromise sanitisation.

On Donnerstag, 29. Mai 2014 16:22:21, Michael Lore [email protected]
wrote:

It does allow the Markdown to render the URL - however in my case that is
the wrong URL. Starting with slash is an absolute reference to the
server root, not a relative reference. My pages are rooted in another
location, so I need a true relative reference.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/87#issuecomment-44536838
.

from blackfriday.

In my case I may be able to disable sanitization. I will try it.

from blackfriday.

Yeah that will work for me because my application doesn't allow random users to input Markdown. So I have a solution - just need to decide how you want sanitization to work for that scenario.

from blackfriday.

Now when Blackfriday no longer attempts to do sanitization internally, it renders them fine again. Closing.

from blackfriday.