Git Product home page Git Product logo

Comments (1)

russellbanks avatar russellbanks commented on May 24, 2024

I've had a look into this and I fixed a few things surrounding this in 82f2245 but when it's ran now, the scope is returned as machine. I believe this is intended behaviour. Take the installers in the installer manifest currently:

Installers:
- Architecture: x86
  Scope: user
  InstallerUrl: https://dl.google.com/dl/chrome/install/googlechromestandaloneenterprise.msi
  InstallerSha256: 0296873AAA22678387DA46AFAF1F24964A02AA15113F13BA07710507930AE966
  ProductCode: '{DA656F67-BC08-3A6B-AB08-77B40F7B6775}'
- Architecture: x86
  Scope: machine
  InstallerUrl: https://dl.google.com/dl/chrome/install/googlechromestandaloneenterprise.msi
  InstallerSha256: 0296873AAA22678387DA46AFAF1F24964A02AA15113F13BA07710507930AE966
  ProductCode: '{DA656F67-BC08-3A6B-AB08-77B40F7B6775}'
- Architecture: x64
  Scope: user
  InstallerUrl: https://dl.google.com/dl/chrome/install/googlechromestandaloneenterprise64.msi
  InstallerSha256: 370E82D3A92C89AA9151A9A756AFC683DDE2AC1E168059BBDBFCF62F2F149EC4
  ProductCode: '{17075A6A-91DC-3207-8443-B245FD58916E}'
- Architecture: x64
  Scope: machine
  InstallerUrl: https://dl.google.com/dl/chrome/install/googlechromestandaloneenterprise64.msi
  InstallerSha256: 370E82D3A92C89AA9151A9A756AFC683DDE2AC1E168059BBDBFCF62F2F149EC4
  ProductCode: '{17075A6A-91DC-3207-8443-B245FD58916E}'

The user scope on here is actually incorrect as the MSI database has an AllUsers value of 1:

An ALLUSERS property value of 1 specifies the per-machine installation context.
https://learn.microsoft.com/windows/win32/msi/allusers

Komac priorities this as this is what is inside the MSI database.

If this really should be the intended output (I can't see why), then I could prioritise what is the previous installer, but I've avoided doing this as manifests often have incorrect data and it makes sense for Komac to "automatically" fix them as they're updated.

from komac.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.