Comments (1)
I've had a look into this and I fixed a few things surrounding this in 82f2245 but when it's ran now, the scope is returned as machine. I believe this is intended behaviour. Take the installers in the installer manifest currently:
Installers:
- Architecture: x86
Scope: user
InstallerUrl: https://dl.google.com/dl/chrome/install/googlechromestandaloneenterprise.msi
InstallerSha256: 0296873AAA22678387DA46AFAF1F24964A02AA15113F13BA07710507930AE966
ProductCode: '{DA656F67-BC08-3A6B-AB08-77B40F7B6775}'
- Architecture: x86
Scope: machine
InstallerUrl: https://dl.google.com/dl/chrome/install/googlechromestandaloneenterprise.msi
InstallerSha256: 0296873AAA22678387DA46AFAF1F24964A02AA15113F13BA07710507930AE966
ProductCode: '{DA656F67-BC08-3A6B-AB08-77B40F7B6775}'
- Architecture: x64
Scope: user
InstallerUrl: https://dl.google.com/dl/chrome/install/googlechromestandaloneenterprise64.msi
InstallerSha256: 370E82D3A92C89AA9151A9A756AFC683DDE2AC1E168059BBDBFCF62F2F149EC4
ProductCode: '{17075A6A-91DC-3207-8443-B245FD58916E}'
- Architecture: x64
Scope: machine
InstallerUrl: https://dl.google.com/dl/chrome/install/googlechromestandaloneenterprise64.msi
InstallerSha256: 370E82D3A92C89AA9151A9A756AFC683DDE2AC1E168059BBDBFCF62F2F149EC4
ProductCode: '{17075A6A-91DC-3207-8443-B245FD58916E}'
The user scope on here is actually incorrect as the MSI database has an AllUsers
value of 1:
An ALLUSERS property value of 1 specifies the per-machine installation context.
https://learn.microsoft.com/windows/win32/msi/allusers
Komac priorities this as this is what is inside the MSI database.
If this really should be the intended output (I can't see why), then I could prioritise what is the previous installer, but I've avoided doing this as manifests often have incorrect data and it makes sense for Komac to "automatically" fix them as they're updated.
from komac.
Related Issues (20)
- [Bug]: fatal alert HandshakeFailure HOT 1
- [Bug]: Multiple URLs Crashes Script HOT 2
- [Bug]: Unable to run on MacOS HOT 1
- [Bug]: `Komac update` does not update `RelativeFilePath` in nested installer HOT 2
- [Bug]: Input 2 installers, only 1 comes out HOT 7
- [Bug]: Invalid zip header HOT 6
- [Feature/Idea]: Edit manifest before creating pull request HOT 2
- [Bug]: Installer Switch missing from previous manifest HOT 1
- [Bug]: Nested nullsoft installer detected as exe HOT 9
- [Feature/Idea]: Interactive menus for updating
- [Bug]: More than 1 quoted URL crashes komac HOT 1
- [Bug]: OpenSSL v1 is a undocumented requirement - Makes Komac unusable on modern systems HOT 4
- [Bug]: The value of "NestedInstallerFiles" went missing
- [Bug]: komac omits `MinimumOSVersion` from previous manifest HOT 1
- [Bug]: Brackets not a valid delimiter around an architecture in a URL HOT 4
- [Bug]: Error when trying to update an existing package to a new version HOT 2
- [Bug]: Unexpected str: "\n" and Checksums in ReleaseNotes
- [Feature/Idea]: Add rpm to ci/cd
- [Bug]: `komac update` removes `AppsAndFeaturesEntries` in `Installers`
- [Bug]: Crashes when these specific URLs are used
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from komac.