Comments (4)
The thinking behind getting a token and not using OAuth flow was that Komac is very very new in this world, and people generally don't trust giving their account access to an unknown OAuth application.
It's the same thing as giving your PAT to an unknown application. I don't see why that would be the reason.
from komac.
The thinking behind getting a token and not using OAuth flow was that Komac is very very new in this world, and people generally don't trust giving their account access to an unknown OAuth application. Once Komac gets popular, and normal contributors start preferring Koamc over YamlCreate and WinGet-Create, we can add it as a feature that will work side-by-side with the normal storing of a token in the Credentials store. This way, (privacy/security)-concerned people will have the option to just give a token, and also have an optional choice to use a more convenient OAuth flow. As of now, I think we should look more into testing and finding bugs in manifest creation, and this issue can be postponed for a while.
from komac.
OAuth application can access some of the private information, which is not possible by just using a PAT.
from komac.
I could do but as @vedantmgoyal2009 said, my concern is I'm not a big corporation like Microsoft so it's difficult to people to trust a GitHub app from a sole developer. I could always add this as an option, but this would be something I'd look into in the future.
from komac.
Related Issues (20)
- [Bug]: Duplicate PRs HOT 5
- [Bug]: Malformed release notes with nested bulletpoints HOT 1
- [Bug]: unmatched InstallerType HOT 3
- [Bug]: Problem with `--resolves`
- [Bug]: komac update error `0: Unsupported file extension`
- [Feature/Idea]: Support 1.6.0 manifests
- [Bug]: bug with release_notes.rs:64 HOT 1
- [Bug]: No architecture was found in the MSI HOT 1
- [Bug]: Relative file path not updating if folder name inside zip changes HOT 3
- [Bug]: Unknown bug HOT 5
- [Feature/Idea]: Add a command to change the basic text in a PR HOT 4
- [Feature/Idea]: add hint that you need to enter `y` (yes) or `n` (no) HOT 1
- [Feature/Idea]: Add new locales or new installer URLs for a existed package
- [Bug]: `zsh: killed komac -v` on macOS
- [Bug]: Fail to detect Betterbird installer locale
- [Bug]: called `Option::unwrap()` on a `None` value HOT 2
- [Feature/Idea]: version recognition and auto-completion `PackageIdentifier` with `komac new`
- [Feature/Idea]: automatically open a link to the created PR HOT 2
- [Bug]: called `Result::unwrap()` on an `Err` value: VariantNotFound
- [Feature/Idea]: Automatically generate next version's links by replacing the version number
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from komac.