[Bug]: Token validity check should be synchronous about komac HOT 3 CLOSED

I ideally want to avoid synchronicity in Komac because having to wait for something to complete doesn't feel like a great user experience. Yamlcreate has this for a second or so as it retrieves all the schemas when it's first ran, so I want to avoid having anything blocking that does the same.

For token validity checks, I've adjusted it in a197424:

There are now 2 "breakpoints" during the Package Identifier prompt. The first one checks whether there is a currently stored token, as this can be retrieved fairly quickly from Windows Credentials. If there isn't the user is prompted for it before the Package Identifier prompt. The second one is after the Package Identifier prompt and checks whether it's valid. If it's not the user will be prompted for a new token.

This is because retrieving the token takes a very small amount of time whilst checking if the token is valid requires a request to GitHub, taking a second or longer. The way I have changed it means that it can do the longer validity check in the background while the user is being asked for the Package Identifier. In a situation where we have the token stored and it's valid, the user shouldn't notice that there are any checks happening.

from komac.

@allcontributors please add @vedantmgoyal2009 for bug

from komac.

@vedantmgoyal2009

I've put up a pull request to add @vedantmgoyal2009! 🎉

from komac.