[Bug]: Detects existing token on first-run about komac HOT 5 CLOSED

Thanks for spotting! Komac gets the token asynchronously in the background (the main amount of time is taken by checking if it's still valid) and if there isn't one, it will prompt for it as soon as it can. This was a recent change and I hadn't considered the use of komac token on first-run so I will push a commit to change this :)

from komac.

It is still not fixed.

from komac.

Sorry, I hadn't tested it if you had a token stored but it wasn't valid. I've made some more changes to it and tested it without a token stored, with a token stored and it's invalid, and with a valid token, and they all work. For komac token, so that there's no hanging or waiting, it will ask the user if they want to change the currently stored token if there is one stored, without checking whether the currently stored one is invalid. It will check if it's valid before it's needed in any of the other commands.

Let me know if you still have the issue.

from komac.

I haven't stored any token yet, still this prompt. It should directly ask for Enter a GitHub token:.

from komac.

Could you check you have a build of the latest commit and that you don't have an entry in Windows Credentials? When I delete Komac's entry in Windows Credentials, I get the prompt Please enter your GitHub personal access token: when using java -jar Komac-0.9.0-all.jar token.

You can access Windows Credentials by searching Credential Manager > Windows Credentials > Look for komac/github-access-token

from komac.