Comments (1)
Hey, this happens because Komac had an issue (#200) where names that had an architecture word in them were identified as architectures:
https://www.website.com/ArmCord.exe
-> arm
Because of this Komac looks for a delimiter before and after architectures to be certain about it:
https://www.website.com/ArmCord-x86.exe
-> x86
The URLs from that pull request don't have delimiters surrounding them, so it resorts to the architecture value in the MSI, which is Intel
.
I'll adjust the function that identifies architectures from URLs to cover this case by considering it being at the end of the URL and followed by .[extension]
.
from komac.
Related Issues (20)
- [Feature/Idea]: Add `--urls` Agreement for `Komac new`
- [Bug]: MalformedInputException
- [Bug]: Manual Update swapped the Urls
- [Bug]: Malsorted URLs in Mozilla-manifests HOT 3
- [Bug]: Unintended Description Formatting HOT 1
- [Bug]: Different fields for each installer got dropped HOT 3
- [Bug]: Closed with unmerged commits
- [Feature/Idea]: Add a command for outputting the manifest locally HOT 2
- [Feature/Idea]: Signing commits HOT 1
- [Feature/Idea]: Document fine-grained permissions necessary for access token HOT 7
- [Bug]: Prompts not shown when same installer link is used for the second time
- Use Gradle Toolchain to pin JDK version
- Rust rewrite HOT 1
- [Bug]: Exception in thread "main" kotlin.UninitializedPropertyAccessException: lateinit property bestMatch has not been initialized HOT 2
- [Feature/Idea]: Mention `run-komac` GitHub Action in readme
- [Feature/Idea]: create manifests with version 1.5.0 by default HOT 3
- docs: Description of --urls needs clarification HOT 2
- [Bug]: Failed to delete downloaded temp file HOT 1
- [Feature/Idea]: Upgrade URLs to HTTPS HOT 2
- [Feature/Idea]: Submit macOS version to Homebrew package manager HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from komac.