[Feature/Idea]: Komac should warn/avoid creating invalid manifests about komac HOT 10 CLOSED

another edge case: versions with spaces in them cannot be uploaded by komac itself, though the write option works fine

Ohkay, so this is the bug that fails some of the winget-releaser runs but we were unable to get the root cause till now. Thanks @superusercode

from komac.

I can break this up into separate issues if necessary, but overall making sure the manifest is valid would help. I should note that the yaml extension in vscode didn't catch the "Accidentally using the same architecture twice (and having no other differences between the two versions).", so just using a yaml checker wouldn't necessarily catch everything. It took the pipeline to catch that.

from komac.

Thanks for reporting! These are all things that can be fixed - I'll address them individually as I work on them

from komac.

Github Release release notes uses a lot of colons and other weird formatting, and gets copied to the release notes field verbatim.

The release notes do get formatted lots in GitHubExtensions.kt as Komac receives it from GitHub in Markdown/HTML. Those release notes are a little odd in the sense of emojis and zalgo text but in terms of making it plain for a manifest, it's what I'd expect. How do you think it should be different/better?

from komac.

Doesn't update product code if it explicitly matches the manifest the updater used to build the new one

I've added updating for the product code version number the same way it is for Display Version ARP Entries etc

from komac.

How do you think it should be different/better?

I think if it's detected as causing the manifest to break then it shouldn't be included. The submitter will have to step in either way to adjust it and put it in right.

from komac.

Another edge case that came up is showing the detected version in dialogue like wingetcreate does as there are some packages that use the detected versioning instead of the actual/advertised version. When updating this package I had to use wingetcreate new to find the version then switch back to komac to make the update.

i.e. https://github.com/microsoft/winget-pkgs/pull/107192/files#diff-ce022bae9f1f6ad3433166cd8c2c7a5325f2500f80460f3559008683cc0cfd33R5-R19

from komac.

another edge case: versions with spaces in them cannot be uploaded by komac itself, though the write option works fine

from komac.

How do you think it should be different/better?

I think if it's detected as causing the manifest to break then it shouldn't be included. The submitter will have to step in either way to adjust it and put it in right.

It doesn't look like that's what caused the pipelines to fail; it would have just needed re-running. The pipelines have a lot of one-off issues like that

The same thing happened in microsoft/winget-pkgs#107215. I added the release notes back in a separate PR and it worked just fine.

The only validation that I believe happens with release notes is checking that it's < 10,000 characters

from komac.

that makes sense, I was wondering since github's syntax highlighting when editing on the web is really weird with manifests like that

from komac.