Comments (8)
sitiom
commented on May 24, 2024
1
That has no effect on the behavior of the installer. The install does write to that location, but the uninstall strings are still located in HKLM (HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\{GUID})
To confirm that the issue is still present:
from komac.
vedantmgoyal9
commented on May 24, 2024
2023-02-20 21:31:17.269 [CORE] WinGet, version [1.5.441-preview], activity [{5406AEB0-B779-484D-B465-C2A2EF98C06A}]
2023-02-20 21:31:17.270 [CORE] OS: Windows.Desktop v10.0.25284.1000
2023-02-20 21:31:17.270 [CORE] Command line Args: "C:\Users\vedan\AppData\Local\Microsoft\WindowsApps\winget.exe" upgrade --id RussellBanks.Komac --exact -s winget --open-logs
2023-02-20 21:31:17.270 [CORE] Package: Microsoft.DesktopAppInstaller v1.20.441.0
2023-02-20 21:31:17.270 [CORE] IsCOMCall:0; Caller: winget-cli
2023-02-20 21:31:17.278 [CLI ] WinGet invoked with arguments: 'upgrade' '--id' 'RussellBanks.Komac' '--exact' '-s' 'winget' '--open-logs'
2023-02-20 21:31:17.278 [CLI ] Found subcommand: upgrade
2023-02-20 21:31:17.278 [CLI ] Leaf command to execute: root:upgrade
2023-02-20 21:31:17.294 [CLI ] Executing command: upgrade
2023-02-20 21:31:17.309 [REPO] Named source requested, found: winget
2023-02-20 21:31:17.325 [CORE] Examining extension: PFN = Microsoft.Winget.Source_8wekyb3d8bbwe, ID = IndexDB
2023-02-20 21:31:17.325 [CORE] Found matching extension.
2023-02-20 21:31:17.375 [REPO] Opening SQLite Index for ImmutableRead at 'C:\Program Files\WindowsApps\Microsoft.Winget.Source_2023.220.1651.303_neutral__8wekyb3d8bbwe\Public\index.db'
2023-02-20 21:31:17.375 [SQL ] Opening SQLite connection #1: 'C:\Program Files\WindowsApps\Microsoft.Winget.Source_2023.220.1651.303_neutral__8wekyb3d8bbwe\Public\index.db' [1, 40]
2023-02-20 21:31:17.377 [REPO] Opened SQLite Index with version [1.6], last write [2023-02-20 21:21:06.000]
2023-02-20 21:31:17.686 [REPO] Creating PredefinedInstalledSource with filter [None]
2023-02-20 21:31:17.686 [REPO] Creating new SQLite Index [4294967295.4294967295] at ':memory:'
2023-02-20 21:31:17.686 [SQL ] Opening SQLite connection #2: ':memory:' [6, 0]
2023-02-20 21:31:17.757 [REPO] Reading MSI UpgradeCodes
2023-02-20 21:31:17.758 [REPO] Examining ARP entries for Machine | X64
2023-02-20 21:31:17.776 [REPO] Examining ARP entries for Machine | X86
2023-02-20 21:31:17.854 [REPO] Reading MSI UpgradeCodes
2023-02-20 21:31:17.856 [REPO] Examining ARP entries for User | X64
2023-02-20 21:31:18.315 [REPO] Opening SQLite Index for ReadWrite at 'C:\Users\vedan\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.db'
2023-02-20 21:31:18.315 [SQL ] Opening SQLite connection #3: 'C:\Users\vedan\AppData\Local\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\Microsoft.Winget.Source_8wekyb3d8bbwe\installed.db' [2, 0]
2023-02-20 21:31:18.317 [REPO] Opened SQLite Index with version [1.6], last write [2023-02-20 20:30:49.000]
2023-02-20 21:31:18.406 [CLI ] Found one app. App id: RussellBanks.Komac App name: Komac
2023-02-20 21:31:18.409 [REPO] Downloading manifest
2023-02-20 21:31:18.409 [CORE] WinINet downloading from url: https://cdn.winget.microsoft.com/cache/manifests/r/RussellBanks/Komac/1.0.4/d166-RussellBanks.Komac.yaml
2023-02-20 21:31:18.459 [CORE] Download hash: 59432829da366f7f6275dad785f4b8495ab9dfc19817ecc2fb8905255038d794
2023-02-20 21:31:18.459 [CORE] Download completed.
2023-02-20 21:31:18.461 [CLI ] Starting installer selection.
2023-02-20 21:31:18.461 [CLI ] Installer [X64,burn,User,en-US] not applicable: Installer scope does not match currently installed scope: User != Machine
2023-02-20 21:31:18.461 [CLI ] Installer [X64,burn,User,en-US] not applicable: Installed package type 'msi' is not compatible with installer type burn
2023-02-20 21:31:18.479 [CLI ] Terminating context: 0x8a15002b at D:\a\_work\1\s\external\pkg\src\AppInstallerCLICore\Workflows\UpdateFlow.cpp:a6
According to the logs, the current installer installs Komac in machine scope 🤔
- Related: #104
from komac.
sitiom
commented on May 24, 2024
According to the logs, the current installer installs Komac in
machinescope 🤔
Yep, it seems like the registry entry is located in HKEY_LOCAL_MACHINE despite installing itself in %localappdata%. @russellbanks
from komac.
russellbanks
commented on May 24, 2024
I'm not really sure why they registry keys are like that :/ Komac uses jPackager from the JDK to package it into an exe (with winPerUserInstall). It could be a bug with that
from komac.
sitiom
commented on May 24, 2024
Hmm, it seems that MSIs write under HKLM regardless of the installation scope. A bunch of Winget packages I have tested have the same issue. This should be raised on the winget-cli repo instead: microsoft/winget-cli#3011
from komac.
mdanish-kh
commented on May 24, 2024
I believe this would be fixed if we used ALLUSERS=2 MSIINSTALLPERUSER=1 switches in the manifest.
I've tested the installation with the switches and it does appear to write in HKEY_CURRENT_USER 👀
from komac.
mdanish-kh
commented on May 24, 2024
My bad, I forgot I had to check the uninstall entries 🤦♂️
from komac.
russellbanks
commented on May 24, 2024
This isn't applicable anymore as Komac has been rewritten in Rust and instead uses Inno Setup for its Windows installers.
from komac.
Related Issues (20)
- [Bug]: fatal alert HandshakeFailure HOT 1
- [Bug]: Multiple URLs Crashes Script HOT 2
- [Bug]: Unable to run on MacOS HOT 1
- [Bug]: `Komac update` does not update `RelativeFilePath` in nested installer HOT 2
- [Bug]: Input 2 installers, only 1 comes out HOT 7
- [Bug]: Invalid zip header HOT 6
- [Feature/Idea]: Edit manifest before creating pull request HOT 2
- [Bug]: Installer Switch missing from previous manifest HOT 1
- [Bug]: Nested nullsoft installer detected as exe HOT 9
- [Feature/Idea]: Interactive menus for updating
- [Bug]: More than 1 quoted URL crashes komac HOT 1
- [Bug]: OpenSSL v1 is a undocumented requirement - Makes Komac unusable on modern systems HOT 4
- [Bug]: The value of "NestedInstallerFiles" went missing
- [Bug]: komac omits `MinimumOSVersion` from previous manifest HOT 1
- [Bug]: Brackets not a valid delimiter around an architecture in a URL HOT 4
- [Bug]: Error when trying to update an existing package to a new version HOT 2
- [Bug]: Unexpected str: "\n" and Checksums in ReleaseNotes
- [Feature/Idea]: Add rpm to ci/cd
- [Bug]: `komac update` removes `AppsAndFeaturesEntries` in `Installers`
- [Bug]: Crashes when these specific URLs are used
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from komac.