Git Product home page Git Product logo

Comments (2)

jgallagher avatar jgallagher commented on May 23, 2024

I'd be fine with adding a message to the assert, but query should not return a Result in this case. Passing in a slice with the wrong length is a programmer error and cannot be recovered from - it's a bug that needs to be fixed.

SqliteError should only have errors from the sqlite bindings, because this library only exists to provide sqlite bindings. :) The few times we've needed to construct one, there's been a reasonable choice to make it look like a SQLite error (e.g., using SQLITE_MISUSE if we can't convert a path to a C string).

from rusqlite.

gsingh93 avatar gsingh93 commented on May 23, 2024

Makes sense. Having a descriptive error message in the assert should be good enough so people don't have to dig into the code to see what assert failed. You should probably double check any other asserts you have too.

from rusqlite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.