reason for clearing IPHONEOS_DEPLOYMENT_TARGET about polly HOT 4 CLOSED

Since there is a comment just saying # ! I assume there is a specific reason why we have to unset it

I don't remember details (commit was made 5 years ago) but yes, # ! means the necessity of this change. Originally all of the environment variables from Xcode was cleared but few of them are really playing critical role, like SDKROOT:

• polly/utilities/polly_clear_environment_variables.cmake

  Line 217 in 6140caa

  unset(ENV{SDKROOT}) # !

Deployment SDK version for iOS can be set by IOS_DEPLOYMENT_SDK_VERSION CMake variable, e.g.:

• polly/ios-10-3-dep-9-0-bitcode.cmake

  Line 15 in 6140caa

  set(IOS_DEPLOYMENT_SDK_VERSION 9.0)

Which will be used to initialize CMAKE_XCODE_ATTRIBUTE_IPHONEOS_DEPLOYMENT_TARGET:

• polly/os/iphone.cmake

  Lines 115 to 126 in 6140caa

  	string(COMPARE EQUAL "${IOS_DEPLOYMENT_SDK_VERSION}" "" _is_empty)
  	if(_is_empty)
  	set(
  	CMAKE_XCODE_ATTRIBUTE_IPHONEOS_DEPLOYMENT_TARGET
  	"${IOS_SDK_VERSION}"
  	)
  	else()
  	set(
  	CMAKE_XCODE_ATTRIBUTE_IPHONEOS_DEPLOYMENT_TARGET
  	"${IOS_DEPLOYMENT_SDK_VERSION}"
  	)
  	endif()

from polly.

I tried passing this variable via --fwd IOS_DEPLOYMENT_SDK_VERSION=9.0 to polly which didn't work. I also tried to set it in a custom PreLoad.cmake to make sure it gets loaded before the toolchain. But it also did not get propagated.
The only place where I could set it seemed to be hardcoded in the toolchain itself, which is why I thought I could use an environment variable her e.g.

set(IOS_DEPLOYMENT_SDK_VERSION "$ENV{IPHONEOS_DEPLOYMENT_TARGET}")

(I admit, not the best solution)

This means I need to create another toolchain file for every change to the deployment target.

Do you have a suggestion how to do this more efficiently and avoid this combinatorial explosion effect?

from polly.

This means I need to create another toolchain file for every change to the deployment target.

Do you have a suggestion how to do this more efficiently and avoid this combinatorial explosion effect?

This is a know drawback (#20). I have some ideas but this involve completely new approach and a lot of work. Straightforward workaround at this moment just create another toolchain.

from polly.

Closing inactive discussion.

from polly.