Git Product home page Git Product logo

Comments (10)

Nimdraug avatar Nimdraug commented on June 17, 2024 3

The issue is that it has been assumed that all font-awesome icons fit in a square, which is true for most of them, but there are quite a few of them that do not, as we have discovered.
Personally I don't think scaling them down is the answer because we need them to have roughly the same height for layout purposes etc. For instance I need the social icons to have the same height, and having the G+ icon be smaller would make things looks out of whack.
What I think should happen is that the view boxes should conform to the actual size of the icon. However, I don't know how easy that will be to work out in the generate script.

from font-awesome-svg-png.

FelisPhasma avatar FelisPhasma commented on June 17, 2024 1

There appears to be a lot of them. How about just scaling it down so it fits in the SVG?

from font-awesome-svg-png.

llwt avatar llwt commented on June 17, 2024

The credit card svgs are cropped as well.

from font-awesome-svg-png.

jelv avatar jelv commented on June 17, 2024

The same for Graduation cap in SVG and PNG.

from font-awesome-svg-png.

ThibaultR avatar ThibaultR commented on June 17, 2024

Same for picture-o.svg and camera.svg and probably a few others...

from font-awesome-svg-png.

FelisPhasma avatar FelisPhasma commented on June 17, 2024

Also weixin.svg

from font-awesome-svg-png.

sprinz avatar sprinz commented on June 17, 2024

Also every variant of cloud.svg

from font-awesome-svg-png.

konpa avatar konpa commented on June 17, 2024

same for Behance

from font-awesome-svg-png.

fahim0623 avatar fahim0623 commented on June 17, 2024

Its there for a lot of them.
Anyone has any idea or quick fix?

from font-awesome-svg-png.

Rush avatar Rush commented on June 17, 2024

@Nimdraug fixed :) I removed the assumption of icons being square., although pixel-grid padding code will try to keep the originally-square icons to be still square.

from font-awesome-svg-png.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.