Comments (10)
The issue is that it has been assumed that all font-awesome icons fit in a square, which is true for most of them, but there are quite a few of them that do not, as we have discovered.
Personally I don't think scaling them down is the answer because we need them to have roughly the same height for layout purposes etc. For instance I need the social icons to have the same height, and having the G+ icon be smaller would make things looks out of whack.
What I think should happen is that the view boxes should conform to the actual size of the icon. However, I don't know how easy that will be to work out in the generate script.
from font-awesome-svg-png.
There appears to be a lot of them. How about just scaling it down so it fits in the SVG?
from font-awesome-svg-png.
The credit card svgs are cropped as well.
from font-awesome-svg-png.
The same for Graduation cap in SVG and PNG.
from font-awesome-svg-png.
Same for picture-o.svg and camera.svg and probably a few others...
from font-awesome-svg-png.
Also weixin.svg
from font-awesome-svg-png.
Also every variant of cloud.svg
from font-awesome-svg-png.
same for Behance
from font-awesome-svg-png.
Its there for a lot of them.
Anyone has any idea or quick fix?
from font-awesome-svg-png.
@Nimdraug fixed :) I removed the assumption of icons being square., although pixel-grid padding code will try to keep the originally-square icons to be still square.
from font-awesome-svg-png.
Related Issues (20)
- Instagram HOT 2
- Missing file-th HOT 1
- Thanks for the inspiration - check out my package `font-awesome-assets` HOT 1
- Error on launching app HOT 7
- Issue with Font Awesome 4.7.0 HOT 1
- Cannot read property 'charCodeAt' of undefined HOT 10
- fa-user-circle missing HOT 2
- SVG is invalid HOT 5
- Bower deprecation; adding complete package to npm? HOT 3
- Asking users for opinion - padding or not? HOT 1
- Break generating svg HOT 1
- Wide icons are not full displayed in the github repo HOT 1
- Upgrade graceful-fs dependency HOT 1
- New icons in Font Awesome 5.0 HOT 6
- Nice job! See my repo `local-icons` in order to use these icons in a very easy way. HOT 4
- rsvg-convert.exe download link is dead
- SVG icon background
- Redo icon
- Licensing HOT 4
- Convert font-awesome pro icons
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from font-awesome-svg-png.