Git Product home page Git Product logo

Comments (5)

groseler avatar groseler commented on June 4, 2024 2

UPDATE: I went to try other versions and in the 1.3.2 is the last one working. Hope it helps.

from html-inline-css-webpack-plugin.

daniele-orlando avatar daniele-orlando commented on June 4, 2024

As additional detail: using filter option, nothing is injected inside the HTML file, even if the filter does match; but the matched files are deleted from the filesystem.

from html-inline-css-webpack-plugin.

runjuu avatar runjuu commented on June 4, 2024

Hi @daniele-orlando , I've updated the peer dependencies and released a new version to NPM. For the filter issue, can you provide a minimal demo to reproduce that?

from html-inline-css-webpack-plugin.

groseler avatar groseler commented on June 4, 2024

As additional detail: using filter option, nothing is injected inside the HTML file, even if the filter does match; but the matched files are deleted from the filesystem.

@runjuu I'm experiencing the same problem with the following example:

new HTMLInlineCSSWebpackPlugin({
        filter: fileName => fileName.includes('critical'),
        styleTagFactory: ({ style }) => {
            return `<style type="text/css">${style}</style>`;
        },
        leaveCSSFile: true,
        replace: {
            removeTarget: true,
            target: '<!-- inline_css_plugin -->',
        },
    }),

The weird part is that if I set the filter for the negative, the other files are included inline:

filter: fileName => !fileName.includes('critical'),

NOTE: I'm using webpack 4

from html-inline-css-webpack-plugin.

github-actions avatar github-actions commented on June 4, 2024

Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

from html-inline-css-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.