AppsFlyer unit tests are disabled about rudder-transformer HOT 3 CLOSED

Hi @orrc ,

Thank you for trying to contribute to Rudderstack code-base.

Cannot find module 'rudder-transformer-cdk' from 'tests/utilities/test-utils.js'

Can you let me know if you've deleted the node_modules and did an npm install after making changes to appsFlyer source ?

However, it looks like the unit tests were entirely commented out, as part of #1033.

Wanted to share that the testing code is present but it is present as part of a utility function and the older way of writing tests has been commented out

Kindly reply back for the question, we'll get back to you as soon as we can!

Thank you

from rudder-transformer.

Hey, thanks for the quick reply!

I took a deeper look, and I think overall things are fine:

• Doing a clean npm install, and running the commented-out code in __tests__/appsFlyer.test.js, there were no more runtime errors — only test failures.
• But as you mention, that commented-out code is old — the remaining code at the bottom of the file executes the processor/router tests without any problems, and all they all pass.
• However, in order to test the AppsFlyer source (which is what I want to do), I should actually be executing a different unit test file: __tests__/appsflyer_source.test.js (which also works fine).

So I guess perhaps just a small code cleanup would be good here, but otherwise feel free to close this :)

from rudder-transformer.

Thanks @orrc . Happy to see that you were able to make things work.
Will be closing this issue. Let us know if anything else comes up.

from rudder-transformer.