Comments (3)
Just checked and I think this might be related to https://github.com/rubygems/rubygems.org/pull/4520/files#diff-7a47d335107fc35c2e79cc9c2b0a195c863594dd2343bcd48a4c770ac4af673cR11
Having some data in and checking the latest version of the profile page, I see the gems not ordered by download count.
If I set the Prosopite.raise flag false
and use the old User.find_by_slug!(params[:id])
query in the ProfilesController#show
action, I see the rubygems_downloaded
scope order correctly applied and the gems order by download count.
We could update the show action to use something like the attached, so we both avoid the n+1 and have the entries order.
@user = User.includes(rubygems_downloaded: %i[most_recent_version gem_download])
.order("gem_downloads_rubygems.count DESC").strict_loading
.find_by_slug!(params[:id])
Seems to work, I'm not sure if it's the best approach though 😀
from rubygems.org.
I have this small #4544 PR covering the profile page gem order updates ready for review. Let me know what you think, thanks! 😀
from rubygems.org.
Thanks for the report @rubyFeedback, indeed this was changed by mistake and will be hopefully fixed by #4544 soon. 🙏
from rubygems.org.
Related Issues (20)
- Event audit log for significant actions
- WebAuthn appears to be hanging. HOT 2
- Menu Javascript broken, logging out impossible HOT 2
- "All versions of #{gem} since #{date}" has paginated date
- In development, LetterOpener web `/letter_opener` is broken/unusable due to Content Security Policy HOT 1
- Add date of last release to search results page HOT 1
- Error importing gems for local development HOT 2
- Alternative to @rubygems_status on Twitter HOT 4
- Changing dependencies didn't change it on the gem page HOT 2
- Remove or replace Twitter/X from email footer HOT 1
- Dashboard Atom feed link broken HOT 2
- Display last released version HOT 6
- Versions published more than 30 days ago cannot be deleted. Please contact RubyGems support to request deletion of this version if it represents a legal or security risk. HOT 1
- Status page header displaying broken help.rubygems.org link
- Improve statistics for downloads HOT 8
- Improve "Access Denied" message by distinguishing "no key" vs "unknown key"
- Allow users to mark gems as no longer being maintained.
- Webauthn CLI login could be much easier
- Refactor permissions to use Pundit for all controlled actions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rubygems.org.