Comments (3)
chaserx
commented on June 17, 2024
@armahillo I wonder how many of these tasks we've completed with the referenced PRs?
from partner.
NiquiCara
commented on June 17, 2024
I'm at Ruby by the Bay, and just completed an audit of this issue by looking at the current code. Here's what still needs to be done:
Services
diaper_bank_client_spec.rb
These need additional tests, but it will be hard to test them without the guard clause stopping non-Prod
- post_request sets the X-Api-Key
Controllers
partners_controller_spec.rb
(Note: html specs seem implemented; but not Json)
- :create is successful via HTML
- :create is successful via JSON
- :update is successful via HTML
- :update is successful via JSON
API
partners_controller_spec.rb
(note: not sure if implemented.. perhaps in spec/requests/api/v1/partners_requests_spec.rb ???)
- :create returns :forbidden if the API key is invalid
- :create is successful
- :update returns :forbidden if the API key is invalid
- :update is successful
- :show returns :forbidden if the API key is invalid
- :show is successful
from partner.
NiquiCara
commented on June 17, 2024
Recommend closing this issue in favor of issues #97, #98, and #99.
from partner.
Related Issues (20)
- Partners can only see 25 results at a time for children and family index
- Add a indicator that the user name on the upper right hand corner is a dropdown.
- User's name on the upper right corner is missing. This is causing the button for opening a dropdown with options to be missing.
- Support for Kit definition on diaperbase and kit requests on partnerbase
- Distribution History HOT 1
- Add Individual Recipients Requests
- Dockerize this app
- Partner Logo and Landing Page
- Change Application Language to be Inclusive
- Integrate brakeman security scans to our Travis CI checks HOT 1
- Empty Bulk Request Item Results in Error
- Rubocop Defaults HOT 2
- Investigate Request Timeouts
- Ability to Delete Uploaded Documents HOT 1
- Dashboard and sidebar language change HOT 1
- Partner Requests Page Language Change HOT 1
- Move Essentials Requests To Card With Description HOT 3
- Upgrade Ruby to 2.7.2
- Allow Reordering of Bulk Requests
- Sandbox Site Warning - Password Resets HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from partner.