Jruby error about ferrum HOT 3 CLOSED

JRuby support is not guaranteed because concurrent-ruby gem has now troubles on JRuby, if you are looking for a threaded solution you might be interested in https://github.com/rubycdp/vessel

from ferrum.

Hey @route @oshanz , I have a Sidekiq Job that opens a website and navigates through 5 pages while filling input fields and checking radio/checkboxes.

I haven't gone through entire Ferrum code, so my patch might be incorrect or doesn't make sense. But, Here's what I did to possibly fix Concurrent::MultipleAssignmentError issue in my app.

  # file: lib/ferrum/browser/client.rb
  def initialize
    # .....
    # 
    while message = @ws.messages.pop
      if INTERRUPTIONS.include?(message["method"])
        @interruptor.async.call(message)
      elsif message.key?("method")
        @subscriber.async.call(message)
      else
        # here's the change
        retries_left = 3
        begin
          @pendings[message["id"]]&.set(message)
        rescue Concurrent::MultipleAssignmentError => e
          retries_left -= 1
          if retries_left > 0
            # retry after sleeping 200ms
            sleep(0.2)
            retry
          end
          raise e
        end
      end
    end
    # .....
  end

After this patch, I am yet to see any issues in my script. Plus, app doesn't throw that exception and terminate anymore.

from ferrum.

@rajuvvadi I'm afraid it's only a hack, which doesn't solve the real issue

from ferrum.