browser.css(...) #=> undefined method `compact' for "(cyclic structure)":String about ferrum HOT 6 CLOSED

Hm, I'll investigate later today guys... There's a failing example that's great!

from ferrum.

Related #13

from ferrum.

I’m getting this as well on the majority of sites. Only seemed to appear after upgrading from Ferrum 0.7 to 0.8. Didn’t change Chrome version or anything. Rolling back to Ferrum 0.7 fixed it.

Ubuntu Linux 18.04
Chromium 83.0.4093.0
Ruby 2.5.7
Ferrum 0.8

from ferrum.

I fixed Ferrum's code that throws the error, but for cycling objects there's nothing Ferrum can do you have to avoid them so instead of getting all articles get what you need (content, images inside article, etc) and avoid returning article node because it's cyclic in JS world and cannot be passed to Ruby world.

from ferrum.

I'm porting my thingy from Selenium::Webdriver to Ferrum. It returns lots of nodes from JS but since it returns them in a single object it all becomes CyclicObject that is impossible to inspect. I edit the cycled? JS, using JSON.stringify and currently I suppose it stucks on some injectedScript that is probably by Ferrum itself and is recursive. Very hard to tell.
I'm debugging it for two days already. I wish there was CyclicReference instead of CyclicObject, similar to how Ruby's inspection works. Looks like the problem is that JS traversing and Ruby traversing are different processes. JS is capable to detect cycle but this information is needed in Ruby. Also the reduce_props looks overcomplicated.

from ferrum.

Maybe my issue will be gone if somehow avoid returning the:

     ["object",
      {"opener"=>nil,
       "length"=>0,
       "closed"=>false,
       "location"=>
        {"href"=>"https://www.google.com/",

thing that I don't even understand where it comes from into the object I return. I return a {...} that I create on fly and so it can't be referred inside but somehow it is. Also if I dump the google.com page to a file and open it the issue does not happen. There is only one div on google.com page that causes it.

UPD: maybe it's because of jsaction? Here is the output of:

[node.outerHTML, JSON.stringify(node, getCircularReplacer())];

This thing is invisible to outerHTML but is visible to Ferrum's serializer. I think it is the cause of cycles.

UPD: ok, it's just a JS library https://github.com/google/jsaction that causes this:

effectively making Ferrum unable to serialize this node from JS to Ruby too because it gets replaced with CyclicObject.

from ferrum.