Git Product home page Git Product logo

Comments (5)

stomar avatar stomar commented on July 30, 2024

Closed with 72af34d.

from www.ruby-lang.org.

chikamichi avatar chikamichi commented on July 30, 2024

@stomar A very neat feature of Github is the ability to auto-close issues from commit messages: https://github.com/blog/1386-closing-issues-via-commit-messages

It encourages you to work on a topic branch and, once you gained positive feedback, merge it on master (where the auto-closing of issue occurs). That's why I worked using PR (but I forgot to use the proper syntax to close related issues :p)

from www.ruby-lang.org.

stomar avatar stomar commented on July 30, 2024

I know, but I don't like coupling of git commit messages to GitHub issues too much. I also prefer rebasing my topic branches and fast forwarding over merging of pull requests.

from www.ruby-lang.org.

chikamichi avatar chikamichi commented on July 30, 2024

Ok. Actually I kind of do the same: rebasing master onto topic branches, then fast-forwarding on master. I like opening a PR on Github though, as it gives an opportunity to discuss the diff and the "request" it backs. I just don't use their merge button to close the PR. That explains why I did not use the "Fixes #XYZ" trick on my PR, then ;)

from www.ruby-lang.org.

stomar avatar stomar commented on July 30, 2024

Granted, if feedback is needed. Regarding your current pull requests, the diffs itself are no-brainers, the only question is whether the changes should be made or not. (For an essentially unmaintained site, pointing to the English feed might be a good idea.)

from www.ruby-lang.org.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.